From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Christoph Heiss <c.heiss@proxmox.com>
Subject: [pve-devel] applied: [PATCH installer v3 0/2] assistant: clean up glob patterns & regexes
Date: Thu, 14 Nov 2024 20:53:09 +0100 [thread overview]
Message-ID: <cb8239c7-9ccd-462e-ac73-b06a72e06302@proxmox.com> (raw)
In-Reply-To: <20241114141533.694491-1-c.heiss@proxmox.com>
Am 14.11.24 um 15:15 schrieb Christoph Heiss:
> The proxmox-auto-install-assistant uses regexes for udev property
> matching, which can be simplified by some simple prefix matching and
> splitting on '='.
>
> The latter also significantly reduces binary size (-46%) due to the
> removing the regex dependency, for details see patch #2.
>
> Overall no functional changes in this series.
>
> history
> =======
>
> v2: https://lore.proxmox.com/pve-devel/20240513094936.412650-1-c.heiss@proxmox.com/
> v1: https://lists.proxmox.com/pipermail/pve-devel/2024-May/063802.html
>
> Changes v2 -> v3:
> * rebased on latest master, dropping applied & obsolete patches
>
> Changes v1 -> v2:
> * rebased on latest master
>
> Christoph Heiss (2):
> tree-wide: run rustfmt, fix clippy warnings
> assistant: avoid regex for simple prefix matching
>
> proxmox-auto-install-assistant/src/main.rs | 61 +++++++++-----------
> proxmox-auto-installer/tests/parse-answer.rs | 2 +-
> proxmox-installer-common/src/setup.rs | 5 +-
> proxmox-tui-installer/src/views/mod.rs | 2 +-
> 4 files changed, 32 insertions(+), 38 deletions(-)
>
applied both patches, thanks!
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2024-11-14 19:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-14 14:15 [pve-devel] " Christoph Heiss
2024-11-14 14:15 ` [pve-devel] [PATCH installer v3 1/2] tree-wide: run rustfmt, fix clippy warnings Christoph Heiss
2024-11-14 14:15 ` [pve-devel] [PATCH installer v3 2/2] assistant: avoid regex for simple prefix matching Christoph Heiss
2024-11-14 19:53 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cb8239c7-9ccd-462e-ac73-b06a72e06302@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=c.heiss@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.