From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Stefan Reiter <s.reiter@proxmox.com>
Subject: [pve-devel] applied: [PATCH qemu-server 1/2] use KillMode 'process' for systemd scope
Date: Wed, 23 Jun 2021 12:06:53 +0200 [thread overview]
Message-ID: <cb2dec51-d1ac-e883-b143-9ce3d42ab38d@proxmox.com> (raw)
In-Reply-To: <20210621163542.1752647-2-s.reiter@proxmox.com>
On 21.06.21 18:35, Stefan Reiter wrote:
> KillMode 'none' is deprecated, and systemd loudly complains about that
> in the journal. To avoid the warning, but keep the behaviour the same,
> use KillMode 'process'.
>
> This mode does two things differently, which we have to stop it from
> doing:
> * it sends SIGTERM right when the scope is cancelled (e.g. on shutdown)
> -> but only to the "root" process, which in our case is the worker
> instance forking QEMU, so it is already dead by the time this happens
> * it sends SIGKILL to *all* children after a timeout
> -> can be avoided by setting either SendSIGKILL to false, or
> TimeoutStopUSec to infinity - for safety, we do both
>
> In my testing, this replicated the previous behaviour exactly, but
> without using the deprecated 'none' mode.
>
> Signed-off-by: Stefan Reiter <s.reiter@proxmox.com>
> ---
>
> Depends on updated pve-common from patch 2.
>
> PVE/QemuServer.pm | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
>
applied, thanks!
next prev parent reply other threads:[~2021-06-23 10:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-21 16:35 [pve-devel] [PATCH 0/2] Work around systemd warning about KillMode 'none' Stefan Reiter
2021-06-21 16:35 ` [pve-devel] [PATCH qemu-server 1/2] use KillMode 'process' for systemd scope Stefan Reiter
2021-06-22 6:02 ` Thomas Lamprecht
2021-06-22 7:23 ` Stefan Reiter
2021-06-23 10:06 ` Thomas Lamprecht [this message]
2021-06-21 16:35 ` [pve-devel] [PATCH common 2/2] systemd: allow SendSIGKILL and TimeoutStopUSec dbus properties Stefan Reiter
2021-06-22 5:45 ` [pve-devel] applied: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cb2dec51-d1ac-e883-b143-9ce3d42ab38d@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=s.reiter@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.