Re: [pve-devel] [PATCH manager 0/2] fix #5570 ceph mds: allow custom MDS IDs from the UI

[Christoph Heiss <c.heiss@proxmox.com>]

Tested this on a small 3-node cluster, works as advertised. Code looks
good too, just one small comment on the second patch.

But otherwise please consider the series at least:

Tested-by: Christoph Heiss <c.heiss@proxmox.com>

On Wed, Jul 10, 2024 at 02:42:58PM GMT, Aaron Lauterer wrote:
> The ID for the MDS cannot start with a number [0]. The first patch adds
> a check for this.
>
> The second patch is the actual fix, by reworking the edit window when
> adding new MDS'.
>
> By allowing the users to set the name of the MDS directly, we can catch
> the situation where the hostname starts with a number and let the user
> decide how it should be named. Similar to what they can already do on
> the CLI.
>
>
> Another approach would be to leave the UI as is and catch the situation
> in the backend. If an ID that starts with a number is detected, we could
> prepend it with a default string.
>
> [0] https://docs.ceph.com/en/latest/man/8/ceph-mds/
>
> Aaron Lauterer (2):
>   api: ceph mds: avoid creating MDS when ID starts with number
>   fix#5570 ui: ceph: make MDS ID configurable
>
>  PVE/API2/Ceph/MDS.pm             |  2 ++
>  www/manager6/ceph/ServiceList.js | 21 +++++++++++----------
>  2 files changed, 13 insertions(+), 10 deletions(-)
>
> --
> 2.39.2
>
>
>
> _______________________________________________
> pve-devel mailing list
> pve-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
>
>


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel