From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox Datacenter Manager development discussion
<pdm-devel@lists.proxmox.com>,
Dominik Csapak <d.csapak@proxmox.com>
Subject: [pdm-devel] applied: [PATCH datacenter-manager 2/2] server: api: task: return upid in status
Date: Wed, 29 Jan 2025 18:31:30 +0100 [thread overview]
Message-ID: <cafe3f69-7e3b-42a5-94e9-07a9f9217083@proxmox.com> (raw)
In-Reply-To: <20250129104450.1286995-2-d.csapak@proxmox.com>
Am 29.01.25 um 11:44 schrieb Dominik Csapak:
> upid was not in params, since it's an extra parameter, so simply use that
>
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> server/src/api/nodes/tasks.rs | 8 ++------
> 1 file changed, 2 insertions(+), 6 deletions(-)
>
>
applied, thanks!
I reworded and extended the commit message a bit though, it wasn't exactly wrong,
but the subject could IMO interpreted as this commit adding a new property to the
return value, while it actually fixed returning the already existing upid property.
_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel
next prev parent reply other threads:[~2025-01-29 17:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-29 10:44 [pdm-devel] [PATCH datacenter-manager 1/2] ui: pve tree: make name column collapse the text Dominik Csapak
2025-01-29 10:44 ` [pdm-devel] [PATCH datacenter-manager 2/2] server: api: task: return upid in status Dominik Csapak
2025-01-29 17:31 ` Thomas Lamprecht [this message]
2025-01-29 17:22 ` [pdm-devel] [PATCH datacenter-manager 1/2] ui: pve tree: make name column collapse the text Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cafe3f69-7e3b-42a5-94e9-07a9f9217083@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pdm-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal