From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Christoph Heiss <c.heiss@proxmox.com>
Subject: Re: [pve-devel] [PATCH installer] auto: add some error context when loading the first-boot executable
Date: Tue, 8 Apr 2025 11:23:29 +0200 [thread overview]
Message-ID: <cae564f7-c449-4fcf-af57-4058c417cd76@proxmox.com> (raw)
In-Reply-To: <20250408090614.223392-1-c.heiss@proxmox.com>
Am 08.04.25 um 11:06 schrieb Christoph Heiss:
> @@ -47,7 +47,9 @@ fn setup_first_boot_executable(first_boot: &FirstBootHookInfo) -> Result<()> {
> }
> }
> FirstBootHookSourceMode::FromIso => {
> - Some(fs::read(format!("/cdrom/{FIRST_BOOT_EXEC_NAME}"))?)
> + Some(fs::read(format!("/cdrom/{FIRST_BOOT_EXEC_NAME}")).context(
> + "failed loading first-boot executable from ISO (was --on-first-boot specified?)",
Definitively better than the status quo, but as user I would then ask
myself how I can pass that flag to the installer, so maybe word it
something like:
"failed loading first-boot executable from ISO (was ISO prepared with --on-first-boot specified?"
Or is this caught already earlier?
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2025-04-08 9:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-08 9:06 Christoph Heiss
2025-04-08 9:23 ` Thomas Lamprecht [this message]
2025-04-08 9:29 ` Christoph Heiss
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cae564f7-c449-4fcf-af57-4058c417cd76@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=c.heiss@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal