From: Christian Ebner <c.ebner@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: Re: [pbs-devel] [PATCH proxmox] s3 client: fix invalid request for empty delete_objects call
Date: Wed, 23 Jul 2025 11:27:15 +0200 [thread overview]
Message-ID: <ca42599a-46d6-4f9a-9243-6488ae9c2f97@proxmox.com> (raw)
In-Reply-To: <20250723091357.353331-1-c.ebner@proxmox.com>
On 7/23/25 11:15 AM, Christian Ebner wrote:
> The s3 client's object_delete method does not correctly handle cases
> where an empty list of object keys is passed via the parameters,
> resulting in an `invalid request` error.
>
> Handle this by early returning in case of an empty list, thereby also
> skipping the unneeded api request altogether.
>
> This indirectly fixes the snapshot directory cleanup for
> proxmox-backup-client benchmark or aborted backups, where no objects
> have been persisted to the object store within the snapshot prefix
> yet, therefore trying to delete the empty list.
>
> Reported-by: Dominik Csapak <d.csapak@proxmox.com>
> Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
> ---
Forgot to include the independent report of the same issue by Lukas,
which was however incorrectly diagnosed as an of out-of-storage-space issue.
Therefore, please include also:
Reported-by: Lukas Wagner <l.wagner@proxmox.com>
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
next prev parent reply other threads:[~2025-07-23 9:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-23 9:13 Christian Ebner
2025-07-23 9:27 ` Christian Ebner [this message]
2025-07-23 13:48 ` [pbs-devel] applied: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ca42599a-46d6-4f9a-9243-6488ae9c2f97@proxmox.com \
--to=c.ebner@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.