[pmg-devel] [PATCH pmg-api] utils: finalize_report: fix encoding for plain-text parts

[pmg-devel] [PATCH pmg-api] utils: finalize_report: fix encoding for plain-text parts

[Stoiko Ivanov]

the syntax for 8-bit encoding in the content-transfer-encoding is
'8bit' not '8-bit' - see RFC2045:
https://www.ietf.org/rfc/rfc2045.html#section-6

We did set the correct value when generating bounces in SMTP.pm (the
only other (non-comment) match for '8-?bit' in the pmg-api sources).

Noticed this while checking why listmonk[0] stumbled on some bounce
mails - it was the spam-reports in the mailbox.

Minimally tested by comparing the output of:
`pmgqm send --receiver xxx@test.domain --debug1`
without and with the patch applied.

[0] application for newsletter mailing lists
    https://github.com/knadh/listmonk
Reported-by: Christian Ebner <c.ebner@proxmox.com>
Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
---
 src/PMG/Utils.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/PMG/Utils.pm b/src/PMG/Utils.pm
index 52b98c01..b9c645eb 100644
--- a/src/PMG/Utils.pm
+++ b/src/PMG/Utils.pm
@@ -1374,7 +1374,7 @@ sub finalize_report {
         $top->attach(
             Data => $plaintext,
             Type => 'text/plain; charset=utf-8',
-            Encoding => '8-bit',
+            Encoding => '8bit',
         );
     }
     if ($html) {
-- 
2.47.3



_______________________________________________
pmg-devel mailing list
pmg-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pmg-devel

Re: [pmg-devel] [PATCH pmg-api] utils: finalize_report: fix encoding for plain-text parts

[Dominik Csapak]

though i didn't test this, the change looks good
and makes sense when reading the MIME::Entity docs and
the linked RFC

Reviewed-by: Dominik Csapak <d.csapak@proxmox.com>

On 1/23/26 10:40 AM, Stoiko Ivanov wrote:
> the syntax for 8-bit encoding in the content-transfer-encoding is
> '8bit' not '8-bit' - see RFC2045:
> https://www.ietf.org/rfc/rfc2045.html#section-6
> 
> We did set the correct value when generating bounces in SMTP.pm (the
> only other (non-comment) match for '8-?bit' in the pmg-api sources).
> 
> Noticed this while checking why listmonk[0] stumbled on some bounce
> mails - it was the spam-reports in the mailbox.
> 
> Minimally tested by comparing the output of:
> `pmgqm send --receiver xxx@test.domain --debug1`
> without and with the patch applied.
> 
> [0] application for newsletter mailing lists
>      https://github.com/knadh/listmonk
> Reported-by: Christian Ebner <c.ebner@proxmox.com>
> Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
> ---
>   src/PMG/Utils.pm | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/PMG/Utils.pm b/src/PMG/Utils.pm
> index 52b98c01..b9c645eb 100644
> --- a/src/PMG/Utils.pm
> +++ b/src/PMG/Utils.pm
> @@ -1374,7 +1374,7 @@ sub finalize_report {
>           $top->attach(
>               Data => $plaintext,
>               Type => 'text/plain; charset=utf-8',
> -            Encoding => '8-bit',
> +            Encoding => '8bit',
>           );
>       }
>       if ($html) {



_______________________________________________
pmg-devel mailing list
pmg-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pmg-devel