Re: [pve-devel] [PATCH manager] api: factor out shell command schema

From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
	Wolfgang Bumiller <w.bumiller@proxmox.com>
Subject: Re: [pve-devel] [PATCH manager] api: factor out shell command schema
Date: Wed, 3 Sep 2025 18:01:22 +0200	[thread overview]
Message-ID: <c9db6455-c5a5-48ab-b039-1ce665aba0f7@proxmox.com> (raw)
In-Reply-To: <20250902125516.346145-1-w.bumiller@proxmox.com>

Am 02.09.25 um 14:55 schrieb Wolfgang Bumiller:
> So we only sort the enum keys once and the documentation and API dumps
> don't keep reordering them, and to deduplicate the cmd and cmd-opts
> schema.
> 
> Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
> ---
>  PVE/API2/Nodes.pm | 68 ++++++++++++++---------------------------------
>  1 file changed, 20 insertions(+), 48 deletions(-)
> 
> diff --git a/PVE/API2/Nodes.pm b/PVE/API2/Nodes.pm
> index ce7eecaf1..636789277 100644
> --- a/PVE/API2/Nodes.pm
> +++ b/PVE/API2/Nodes.pm
> @@ -1103,6 +1103,23 @@ my $shell_cmd_map = {
>      },
>  };
>  
> +my @shell_cmd_params = (

not really much difference in practice, but why not a %hash map?

> +    cmd => {
> +        type => 'string',
> +        description => "Run specific command or default to login (requires 'root\@pam')",
> +        enum => [sort keys %$shell_cmd_map],
> +        optional => 1,
> +        default => 'login',
> +    },
> +    'cmd-opts' => {
> +        type => 'string',
> +        description => "Add parameters to a command. Encoded as null terminated strings.",
> +        requires => 'cmd',
> +        optional => 1,
> +        default => '',
> +    },
> +);
> +

_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel