all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Stefan Sterz <s.sterz@proxmox.com>
To: Lukas Wagner <l.wagner@proxmox.com>,
	Proxmox Backup Server development discussion
	<pbs-devel@lists.proxmox.com>
Subject: Re: [pbs-devel] [PATCH proxmox 2/4] ldap: add check_connection function
Date: Mon, 26 Jun 2023 14:24:40 +0200	[thread overview]
Message-ID: <c9cba0db-088e-bc95-7894-ff2431eaa1da@proxmox.com> (raw)
In-Reply-To: <64613c59-ec49-ac47-3211-a29b1db02d70@proxmox.com>

On 26.06.23 14:23, Lukas Wagner wrote:
> Hello,
> 
> On 6/26/23 11:39, Stefan Sterz wrote:
>> +    /// Helper to check if a connection with the current
>> configuration is possible.
>> +    ///
>> +    /// This performs a search with the current configuration. If the
>> search succeeds `Ok(()) is
>> +    /// returned, otherwise an `Error` is returned.
>> +    pub async fn check_connection(&self) -> Result<(), Error> {
> 
> The `proxmox-ldap` crate actually has some integration tests, running
> tests against a
> real LDAP server (glauth). For reference, take a look at
> `tests/glauth.rs` and
> `tests/run_integration_tests.sh`. They are ignored by default, since
> they require the
> `glauth` binary in your `PATH`.
> 
> It would be cool if you could add some tests for this new function. Can
> of course happen in a
> followup patch! :)
> 
> 
Ah thanks, yeah i'll look into it, but i wanted to get this out in time
for the next release. the tests probably won't make it in time, hope
that's alright.




  reply	other threads:[~2023-06-26 12:25 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-26  9:39 [pbs-devel] [PATCH proxmox(-backup), widget-toolkit 0/4] improve ldap configuration handling Stefan Sterz
2023-06-26  9:39 ` [pbs-devel] [PATCH proxmox 1/4] ldap: remove support for unauthenticated binds Stefan Sterz
2023-06-26 13:00   ` [pbs-devel] applied: " Wolfgang Bumiller
2023-06-26  9:39 ` [pbs-devel] [PATCH proxmox 2/4] ldap: add check_connection function Stefan Sterz
2023-06-26 12:23   ` Lukas Wagner
2023-06-26 12:24     ` Stefan Sterz [this message]
2023-06-26 12:57       ` Wolfgang Bumiller
2023-06-26  9:39 ` [pbs-devel] [PATCH proxmox-backup 3/4] access: ldap check connection on creation and change Stefan Sterz
2023-06-26 12:36   ` Lukas Wagner
2023-06-26 12:40     ` Stefan Sterz
2023-06-26 12:59       ` Wolfgang Bumiller
2023-06-26 13:17         ` Stefan Sterz
2023-06-26  9:39 ` [pbs-devel] [PATCH widget-toolkit 4/4] window: ldap auth edit forbid specifying a bind_dn without a password Stefan Sterz
2023-06-26 13:04   ` [pbs-devel] applied: " Wolfgang Bumiller
2023-06-26 18:30   ` [pbs-devel] " Thomas Lamprecht
2023-06-27  7:23     ` Stefan Sterz
2023-06-26 12:39 ` [pbs-devel] [PATCH proxmox(-backup), widget-toolkit 0/4] improve ldap configuration handling Lukas Wagner
2023-06-26 12:46 ` Stefan Hanreich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c9cba0db-088e-bc95-7894-ff2431eaa1da@proxmox.com \
    --to=s.sterz@proxmox.com \
    --cc=l.wagner@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal