all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
	Maximiliano Sandoval <m.sandoval@proxmox.com>
Subject: [pve-devel] applied: [PATCH qemu-server v2 1/2] vm-network-scripts: move scripts to /usr/libexec
Date: Mon, 7 Apr 2025 16:04:18 +0200	[thread overview]
Message-ID: <c9aff49e-4c42-48f7-9de1-1a77fd3bb863@proxmox.com> (raw)
In-Reply-To: <20250218133206.318155-1-m.sandoval@proxmox.com>

Am 18.02.25 um 14:32 schrieb Maximiliano Sandoval:
> Moves the network scripts from /var/lib/qemu-server into
> /usr/libexec/qemu-server.
> 
> /usr/libexec is described as binaries run by programs which are not
> intended to be directly executed by the user on [FHS 4.7]. On the other
> hand /var/lib corresponds to variable state information, which does not
> fit the use case here, see [FHS 5.8].
> 
> For the sake of preventing race conditions we ship both versions until
> version 9.
> 
> [FHS 4.7]: https://refspecs.linuxfoundation.org/FHS_3.0/fhs/ch04s07.html
> [FHS 5.8]: https://refspecs.linuxfoundation.org/FHS_3.0/fhs/ch05s08.html
> 
> Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
> ---
> 
> Differences from v1:
>  - Ship both versions until v9 to prevent race conditions.
>  - Rebase
> 
>  PVE/QemuServer.pm                     | 4 ++--
>  vm-network-scripts/Makefile           | 6 ++++++
>  vm-network-scripts/pve-bridge-hotplug | 2 +-
>  3 files changed, 9 insertions(+), 3 deletions(-)
> 
>

applied this one already, thanks!

The second patch needs to be refreshed due to some changes to the cfg2cmd
output.


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


      parent reply	other threads:[~2025-04-07 14:04 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-18 13:32 [pve-devel] " Maximiliano Sandoval
2025-02-18 13:32 ` [pve-devel] [PATCH qemu-server v2 2/2] test: Adapt to changes in network scripts location Maximiliano Sandoval
2025-04-07 15:31   ` Thomas Lamprecht
2025-04-07 14:04 ` Thomas Lamprecht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c9aff49e-4c42-48f7-9de1-1a77fd3bb863@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=m.sandoval@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal