all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Stefan Hanreich <s.hanreich@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: Re: [pve-devel] [PATCH pve-manager] sdn: evpn: allow empty primary exit node in zone form
Date: Thu, 22 Feb 2024 17:42:12 +0100	[thread overview]
Message-ID: <c85033c1-7139-41c0-871b-b9a00f1bd708@proxmox.com> (raw)
In-Reply-To: <20240213104049.2190611-1-aderumier@odiso.com>

This was broken when adding a new EVPN zone and there's an easier way
built-in to our widget toolkit. I've taken the liberty of sending a v2
and mentioning you [1].

[1] https://lists.proxmox.com/pipermail/pve-devel/2024-February/061924.html

On 2/13/24 11:40, Alexandre Derumier wrote:
> It's broken since
> https://git.proxmox.com/?p=pve-network.git;a=commit;h=3e3cafabaf955d53c4c2d4e346bf5c3a5c6d1852
> 
> Signed-off-by: Alexandre Derumier <aderumier@odiso.com>
> ---
>  www/manager6/sdn/zones/EvpnEdit.js | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/www/manager6/sdn/zones/EvpnEdit.js b/www/manager6/sdn/zones/EvpnEdit.js
> index a08faef2..2e792322 100644
> --- a/www/manager6/sdn/zones/EvpnEdit.js
> +++ b/www/manager6/sdn/zones/EvpnEdit.js
> @@ -10,6 +10,11 @@ Ext.define('PVE.sdn.zones.EvpnInputPanel', {
>  	    values.type = me.type;
>  	}
>  
> +	if (values['exitnodes-primary'] === '') {
> +	    delete values['exitnodes-primary'];
> +	    values.delete.push('exitnodes-primary');
> +	}
> +
>  	return values;
>      },
>  




      reply	other threads:[~2024-02-22 16:42 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-13 10:40 Alexandre Derumier
2024-02-22 16:42 ` Stefan Hanreich [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c85033c1-7139-41c0-871b-b9a00f1bd708@proxmox.com \
    --to=s.hanreich@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal