* [pve-devel] [PATCH manager] ui: window/Settings: fix labelWidth for saved user name
@ 2021-02-19 14:27 Dominik Csapak
2021-02-19 15:36 ` [pve-devel] applied: " Thomas Lamprecht
0 siblings, 1 reply; 2+ messages in thread
From: Dominik Csapak @ 2021-02-19 14:27 UTC (permalink / raw)
To: pve-devel
Somewhere during rendering of the window, extjs wants to add 5px to
the labelwidth for the surrounding container. Having a string here
results in the container having a width of 1505px instead of 155px and
the value of the field is far off to the right and not visible.
Changing to a number fixes that.
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
www/manager6/window/Settings.js | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/www/manager6/window/Settings.js b/www/manager6/window/Settings.js
index c92d2a25..75feb373 100644
--- a/www/manager6/window/Settings.js
+++ b/www/manager6/window/Settings.js
@@ -238,7 +238,7 @@ Ext.define('PVE.window.Settings', {
{
xtype: 'displayfield',
fieldLabel: gettext('Saved User Name') + ':',
- labelWidth: '150',
+ labelWidth: 150,
stateId: 'login-username',
reference: 'savedUserName',
flex: 1,
--
2.20.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* [pve-devel] applied: [PATCH manager] ui: window/Settings: fix labelWidth for saved user name
2021-02-19 14:27 [pve-devel] [PATCH manager] ui: window/Settings: fix labelWidth for saved user name Dominik Csapak
@ 2021-02-19 15:36 ` Thomas Lamprecht
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Lamprecht @ 2021-02-19 15:36 UTC (permalink / raw)
To: Proxmox VE development discussion, Dominik Csapak
On 19.02.21 15:27, Dominik Csapak wrote:
> Somewhere during rendering of the window, extjs wants to add 5px to
> the labelwidth for the surrounding container. Having a string here
> results in the container having a width of 1505px instead of 155px and
> the value of the field is far off to the right and not visible.
>
> Changing to a number fixes that.
weird but ok
>
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> www/manager6/window/Settings.js | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>
applied, thanks!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-02-19 15:36 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-19 14:27 [pve-devel] [PATCH manager] ui: window/Settings: fix labelWidth for saved user name Dominik Csapak
2021-02-19 15:36 ` [pve-devel] applied: " Thomas Lamprecht
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal