From: Lorenz Stechauner <l.stechauner@proxmox.com>
To: Thomas Lamprecht <t.lamprecht@proxmox.com>,
Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] applied: [PATCH v9 manager 2/5] api: nodes: refactor aplinfo to use common download function
Date: Mon, 21 Jun 2021 09:53:23 +0200 [thread overview]
Message-ID: <c804c400-5ad6-8bf1-bdf7-e92625d621a3@proxmox.com> (raw)
In-Reply-To: <07cd6245-dced-f397-02da-0873851f3a31@proxmox.com>
On 18.06.21 18:58, Thomas Lamprecht wrote:
> On 16.06.21 11:36, Lorenz Stechauner wrote:
>> a common function to download arbitrary files from urls has been
>> defined as PVE::Tools::download_file_from_url and is now used.
>>
>> Signed-off-by: Lorenz Stechauner <l.stechauner@proxmox.com>
>> ---
>> PVE/API2/Nodes.pm | 93 +++++++++--------------------------------------
>> 1 file changed, 17 insertions(+), 76 deletions(-)
>>
>>
> applied, with the $rpcenv/$user re-definitions dropped in a followup, plus
> some more cleanup (please check if it seems OK for you), thanks!
Had a look at the followups. they look good to me
next prev parent reply other threads:[~2021-06-21 7:53 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-16 9:35 [pve-devel] [PATCH-SERIES v9 manager/common/storage] fix #1710: add download from url button Lorenz Stechauner
2021-06-16 9:35 ` [pve-devel] [PATCH v9 common 1/2] tools: download_file_from_url: adapt error messages to start at new line Lorenz Stechauner
2021-06-16 10:45 ` [pve-devel] applied: " Thomas Lamprecht
2021-06-16 9:35 ` [pve-devel] [PATCH v9 common 2/2] tools: download_file_from_url: move check for existing file outside eval Lorenz Stechauner
2021-06-16 10:46 ` [pve-devel] applied: " Thomas Lamprecht
2021-06-16 9:35 ` [pve-devel] [PATCH v9 storage 1/1] status: add download_url method Lorenz Stechauner
2021-06-21 7:29 ` Thomas Lamprecht
2021-06-16 9:36 ` [pve-devel] [PATCH v9 manager 1/5] api: nodes: add query_url_metadata method Lorenz Stechauner
2021-06-16 9:36 ` [pve-devel] [PATCH v9 manager 2/5] api: nodes: refactor aplinfo to use common download function Lorenz Stechauner
2021-06-18 16:39 ` Thomas Lamprecht
2021-06-18 16:58 ` [pve-devel] applied: " Thomas Lamprecht
2021-06-21 7:53 ` Lorenz Stechauner [this message]
2021-06-16 9:36 ` [pve-devel] [PATCH v9 manager 3/5] ui: add HashAlgorithmSelector Lorenz Stechauner
2021-06-21 9:26 ` [pve-devel] applied: " Thomas Lamprecht
2021-06-16 9:36 ` [pve-devel] [PATCH v9 manager 4/5] ui: Utils: change download task format Lorenz Stechauner
2021-06-16 9:36 ` [pve-devel] [PATCH v9 manager 5/5] fix #1710: ui: storage: add download from url button Lorenz Stechauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c804c400-5ad6-8bf1-bdf7-e92625d621a3@proxmox.com \
--to=l.stechauner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=t.lamprecht@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.