From: Christian Ebner <c.ebner@proxmox.com>
To: Robert Obkircher <r.obkircher@proxmox.com>, pbs-devel@lists.proxmox.com
Subject: Re: [PATCH v1 proxmox 1/2] proxmox-sys: avoid unnecessary conversion in replace_file
Date: Mon, 29 Jun 2026 13:12:40 +0200 [thread overview]
Message-ID: <c73cb7db-1dd2-4186-ac13-f7bd2c94e7c5@proxmox.com> (raw)
In-Reply-To: <20260617105000.232928-2-r.obkircher@proxmox.com>
On 6/17/26 12:49 PM, Robert Obkircher wrote:
> Since make_tmp_file already returns a File there is no need to convert
> to a raw file descriptor and back.
>
> Fixes: 26c06df4 ("make_tmp_file: return File instead of Fd")
> Signed-off-by: Robert Obkircher <r.obkircher@proxmox.com>
Reviewed-by: Christian Ebner <c.ebner@proxmox.com>
next prev parent reply other threads:[~2026-06-29 11:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-17 10:49 [PATCH v1 proxmox 0/2] improve proxmox-sys::fs::replace_file Robert Obkircher
2026-06-17 10:49 ` [PATCH v1 proxmox 1/2] proxmox-sys: avoid unnecessary conversion in replace_file Robert Obkircher
2026-06-29 11:12 ` Christian Ebner [this message]
2026-06-17 10:49 ` [PATCH v1 proxmox 2/2] fix #7690: proxmox-sys: close fd before rename/unlink " Robert Obkircher
2026-06-29 11:18 ` Christian Ebner
2026-06-30 13:24 ` Robert Obkircher
2026-06-30 15:02 ` Christian Ebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c73cb7db-1dd2-4186-ac13-f7bd2c94e7c5@proxmox.com \
--to=c.ebner@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
--cc=r.obkircher@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.