Re: [PATCH v1 proxmox 2/2] fix #7690: proxmox-sys: close fd before rename/unlink in replace_file

[Robert Obkircher <r.obkircher@proxmox.com>]

On 29.06.26 13:18, Christian Ebner wrote:
> On 6/17/26 12:49 PM, Robert Obkircher wrote:
>> Fix the rename operation on WORM file systems and allow FUSE file
>> systems to unlink without creating temporary .fuse_hidden files.
>
> question: what about other helpers using a similar pattern when
> removing a temp file in error case, e.g. unlink() after file content
> writing or fsync() failed while still holding an open file
> descriptor in atomic_open_or_create_file()? These will produce the
> .fuse_hidden files as well? 
I think so, but .fuse_hidden files are not really harmful, and it
seems like we mostly use that function for lockfiles outside of
datastores.

Should I write a test to verify when .fuse_hidden files are created? I
didn't bother because I wasn't sure how to create a fuse file system
in a test.

But it also seems a bit strange to me that we use mkostemp and
path-based renames in the first place. Creating the file
with O_TMPFILE and linking it into place would definitely be safer.

>
>
> [...]