From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Dominik Csapak <d.csapak@proxmox.com>
Subject: [pve-devel] applied: [PATCH widget-toolkit] Utils: clear cookies with secure flag set
Date: Fri, 18 Mar 2022 16:29:35 +0100 [thread overview]
Message-ID: <c738575b-0fda-fa06-b180-5768f4aeb75f@proxmox.com> (raw)
In-Reply-To: <20220318100011.886719-1-d.csapak@proxmox.com>
On 18/03/2022 11:00, Dominik Csapak wrote:
> otherwise firefox complains with a deprecation warning that the secureflag
> is not set but SameSite to 'None'. Since we cannot know how firefox will
> behave once that behaviour is no longer supported, add the secure flag
> now.
>
> we have to use the 'set' api of ExtJs to do that reliably
>
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> src/Utils.js | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>
applied, thanks! Added a comment in a follow-up though.
prev parent reply other threads:[~2022-03-18 15:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-18 10:00 [pve-devel] " Dominik Csapak
2022-03-18 15:29 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c738575b-0fda-fa06-b180-5768f4aeb75f@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal