Re: [pve-devel] [PATCH docs 2/2] cifs: add options parameter (fix #2920)

[Fiona Ebner <f.ebner@proxmox.com>]

Am 13.05.22 um 15:55 schrieb Stefan Hrdlicka:
> Signed-off-by: Stefan Hrdlicka <s.hrdlicka@proxmox.com>
> ---
> this depends on 1/2 since this changes the documentation :)
> 
>  pve-storage-cifs.adoc | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/pve-storage-cifs.adoc b/pve-storage-cifs.adoc
> index bb4b902..60775a4 100644
> --- a/pve-storage-cifs.adoc
> +++ b/pve-storage-cifs.adoc
> @@ -57,6 +57,10 @@ path::
>  
>  The local mount point. Optional, defaults to `/mnt/pve/<STORAGE_ID>/`.
>  
> +options::
> +
> +CIFS mount options (see `man mount.cifs`).

Maybe add "Additional" and briefly mention that we set some options like
username, vers, etc. based on the other settings?

> +
>  .Configuration Example (`/etc/pve/storage.cfg`)
>  ----
>  cifs: backup
> @@ -64,6 +68,7 @@ cifs: backup
>  	server 10.0.0.11
>  	share VMData
>  	content backup
> +	options noserverino,cache=loose

Reading the man page, cache=loose sounds rather dangerous! I'd rather
have the example use something that can't lead to data corruption in
some scenarios :S

>  	username anna
>  	smbversion 3
>