Re: [pbs-devel] [PATCH proxmox-backup 00/23] add removable datastores

[Lukas Wagner <l.wagner@proxmox.com>]

On 9/15/23 08:54, Hannes Laimer wrote:
> b404eea5 and e5863f7e are not strictly needed, but they made sense in
> this context, so I kept them in this series.
> 

Please refer to the commit message/patch number directly - there is no 
way to find out for me which commits are meant by that :)

Gave these patches a try on the latest master, here is what I found:

- Datastore add UI: Might make sense to restructure the dialog, the 
checkbox for 'removable datastore' influences UI elements that are 
before the checkbox - a user might have entered something to the 
datastore path field before toggling the checkbox.

- I'm not sure if the USB icon is the best choice for a removable data 
store. it could be a hot plugged SATA disk, iSCSI, etc. - maybe change 
this to something more generic if possible?

- UI: datastore summary page: underscore in `/mnt/removeable_datastore` 
is not rendered in my firefox (117.0.1)

- Mounting/Unmounting does not seem to work properly for me, here is 
what I did:
   - New VM with PBS, latest updates
   - Attached second disk
   - Created ext4 partition
   - created new removabale datastore from GUI
     - unmount from CLI (promxox-backup-manager datastore unmount --store
       test) does not seem to have any effect
     - pressing on 'unmount' in the GUI seems to work (verified by
       `mount`), but the GUI still considers the datastore as
        mounted - the `mount` button remains disabled
     - a `promxox-backup-manager datastore mount --store test` on the
       CLI does not seem to have any effect


- There is no way to prepare a disk for the use as a removable datastore 
from the UI alone. We can create a GPT partition table and create an 
ext4 partition on it (via 'Directory'), however this creates a mount 
point for the new partition, so it cannot be used any more when creating 
a datastore. Maybe creating the mount point could be optional?



-- 
- Lukas