all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Alexandre DERUMIER <aderumier@odiso.com>
Cc: pve-devel <pve-devel@pve.proxmox.com>
Subject: Re: [pve-devel] sdn patches ready for review
Date: Fri, 28 Aug 2020 15:09:29 +0200	[thread overview]
Message-ID: <c6846219-0a04-ff6d-cdd4-57e34460647f@proxmox.com> (raw)
In-Reply-To: <1844854487.155436.1598619062646.JavaMail.zimbra@odiso.com>

Hi,

On 8/28/20 2:51 PM, Alexandre DERUMIER wrote:
> Hi everybody,
> 
> I think my summer work on sdn is ready for review.
> I have implemented subnet/nat/ipam/dns registration.

cool!

> 
> I'll stop to add new feature for now, I have planned time in september for fixes,cleanup.

Ok, thanks for the information! I'll allocate a few hours next week to give
initial feedback.
I already skimmed each iteration of your patches shallowly, nothing made any
alarm bells ring, so from what I can tell now, it should head in the right
directions.

The features are definitively nice and I think many PVE users would like to have
them quite a bit.

> Here the different patch series:
> 
> 
> [pve-devel] [PATCH v7 pve-network 00/21] sdn : add subnets management
> https://lists.proxmox.com/pipermail/pve-devel/2020-August/044850.html
> 
> [pve-devel] [PATCH v4 pve-manager 0/8] sdn : add subnets management
> https://lists.proxmox.com/pipermail/pve-devel/2020-August/044775.html
> 
> 
> [pve-devel] [PATCH v4 pve-cluster 0/4] sdn : add subnets management
> https://lists.proxmox.com/pipermail/pve-devel/2020-August/044770.html
> 
> [pve-devel] [PATCH v2 pve-docs 0/2] simple zone + subnet/ipam documentation
> https://lists.proxmox.com/pipermail/pve-devel/2020-August/044874.html
> 
> 
> For testing subnet/ipam in lxc (is really a poc, do not apply) ->
> 
> [pve-devel] [PATCH v2 pve-container] POC : add/del/update ip from vnet-subnet-ipam
> https://lists.proxmox.com/pipermail/pve-devel/2020-August/044781.html
> 
> Currently, if you use a vnet with subnet with registered ipam, and you keep the ip field empty, it'll auto-assign an ip.
> (or you can still defined your own ip, it'll be registered in pam too)
> 
> 

OK. Do you already use this new stuff somewhere in your setups?




  reply	other threads:[~2020-08-28 13:09 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-27 11:16 [pve-devel] [PATCH manager] ContentView: block removal of in-use container image Fabian Ebner
2020-08-28  8:25 ` [pve-devel] applied: " Thomas Lamprecht
2020-08-28 12:51   ` [pve-devel] sdn patches ready for review Alexandre DERUMIER
2020-08-28 13:09     ` Thomas Lamprecht [this message]
2020-08-28 14:17       ` Alexandre DERUMIER
2020-10-05 15:20     ` Alexandre Aderumier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c6846219-0a04-ff6d-cdd4-57e34460647f@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=aderumier@odiso.com \
    --cc=pve-devel@pve.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal