Re: [pve-devel] [PATCH storage] BTRFSPlugin: reuse DirPlugin update/get_volume_attribute

[Thomas Lamprecht <t.lamprecht@proxmox.com>]

Am 4/29/22 um 12:00 schrieb Dominik Csapak:
> this allows setting notes+protected for backups on btrfs
> 
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
>  PVE/Storage/BTRFSPlugin.pm | 20 ++++++++++++++++++--
>  1 file changed, 18 insertions(+), 2 deletions(-)
> 
> diff --git a/PVE/Storage/BTRFSPlugin.pm b/PVE/Storage/BTRFSPlugin.pm
> index be613f4..dd5f139 100644
> --- a/PVE/Storage/BTRFSPlugin.pm
> +++ b/PVE/Storage/BTRFSPlugin.pm
> @@ -138,9 +138,25 @@ sub status {
>      return PVE::Storage::DirPlugin::status($class, $storeid, $scfg, $cache);
>  }
>  
> -# TODO: sub get_volume_attribute {}
> +# FIXME remove on the next APIAGE reset.
> +# Deprecated, use get_volume_attribute instead.
> +sub get_volume_notes {
> +    return PVE::Storage::DirPlugin::get_volume_notes(@_);
> +}
> +
> +# FIXME remove on the next APIAGE reset.
> +# Deprecated, use update_volume_attribute instead.
> +sub update_volume_notes {
> +    return PVE::Storage::DirPlugin::update_volume_notes( @_);
> +}

makes no sense to add these? they are deprecated and unused anyway

>  
> -# TODO: sub update_volume_attribute {}
> +sub get_volume_attribute {
> +    return PVE::Storage::DirPlugin::get_volume_attribute(@_);
> +}
> +
> +sub update_volume_attribute {
> +    return PVE::Storage::DirPlugin::update_volume_attribute(@_);
> +}

This is so trivial that I'm wondering if Wolfgang had a reason to not do it for the
original get_volume_notes that was there long before the BTRFS plugin got added..

>  
>  # croak would not include the caller from within this module
>  sub __error {