From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Christoph Heiss <c.heiss@proxmox.com>
Cc: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH container 1/2] net: Add `link_down` config to allow setting interfaces as disconnected
Date: Tue, 14 Feb 2023 11:20:14 +0100 [thread overview]
Message-ID: <c5c3ec0a-6daa-eb53-8bbf-2019e2159a26@proxmox.com> (raw)
In-Reply-To: <20230214101054.22s7psxojrxmoena@maui.proxmox.com>
On 14/02/2023 11:10, Christoph Heiss wrote:
>> besides from that, the patch here contains quite some unrelated whitespace
>> changes, please avoid that.
> That was intentional (as noted), since there are trailing whitespaces
> all over the file, which can be somewhat annoying if one's editor
> automatically trims trailing whitespaces on save purposefully.
> But I will omit that from the next revision, fine by me.
I never said that fixing it is wrong, but it's completely unrelated for
your change, and thus noise - please do that in a separate patch upfront
for the next revision, then it could have been already applied now ;-)
next prev parent reply other threads:[~2023-02-14 10:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-13 13:56 [pve-devel] [PATCH container/manager 0/2] fix #3413: Add `Disconnect` option for LXC networks Christoph Heiss
2023-02-13 13:56 ` [pve-devel] [PATCH container 1/2] net: Add `link_down` config to allow setting interfaces as disconnected Christoph Heiss
2023-02-13 14:31 ` Wolfgang Bumiller
2023-02-14 9:29 ` Christoph Heiss
2023-02-14 9:52 ` Thomas Lamprecht
2023-02-14 10:10 ` Christoph Heiss
2023-02-14 10:20 ` Thomas Lamprecht [this message]
2023-02-13 13:57 ` [pve-devel] [PATCH manager 2/2] lxc: Add `Disconnect` option for network interfaces Christoph Heiss
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c5c3ec0a-6daa-eb53-8bbf-2019e2159a26@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=c.heiss@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.