From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Fabian Ebner <f.ebner@proxmox.com>
Subject: [pve-devel] applied: [PATCH manager] ui: storage: show no-keeps hint exactly when needed
Date: Tue, 24 Nov 2020 15:47:15 +0100 [thread overview]
Message-ID: <c50597fd-b78f-f865-52cd-484baca67eb9@proxmox.com> (raw)
In-Reply-To: <20201124143136.29247-1-f.ebner@proxmox.com>
On 24.11.20 15:31, Fabian Ebner wrote:
> extracting the logic from the previous checkbox listener into a function, which
> is also called on field changes and once in afterrender. Calling it initially
> makes sure the hint is also displayed at the beginning when editing a storage
> with no retention options configured, and the initial disabling of the input
> fields for the isCreate case now also happens through that call.
>
> Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
> ---
>
> Not too happy about the function name, but couldn't come up with
> anything better.
>
> www/manager6/storage/Base.js | 27 ++++++++++++++++++---------
> 1 file changed, 18 insertions(+), 9 deletions(-)
>
>
applied, thanks!
prev parent reply other threads:[~2020-11-24 14:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-24 14:31 [pve-devel] " Fabian Ebner
2020-11-24 14:47 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c50597fd-b78f-f865-52cd-484baca67eb9@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.