From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>,
Dominik Csapak <d.csapak@proxmox.com>
Subject: [pbs-devel] applied: [PATCH proxmox] proxmox-http: websocket: fix comment about callback
Date: Fri, 4 Feb 2022 17:18:53 +0100 [thread overview]
Message-ID: <c5027b6f-19d3-9c3a-df6a-c19c2e5fde66@proxmox.com> (raw)
In-Reply-To: <20220204095240.2278480-1-d.csapak@proxmox.com>
On 04.02.22 10:52, Dominik Csapak wrote:
> this was once a callback in an early version, but it changed to a
> channel, but the comment was not updated
>
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> proxmox-http/src/websocket/mod.rs | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
>
applied, thanks! I reworded a few comments in a followup, as some where a bit
hard to grasp, or used the same word relatively often in one sentence.
Also dropped a doc-comment reference of "auto detecing binary/text frame" on
the writer, was probably forgotten when removing that in commit 232d875
prev parent reply other threads:[~2022-02-04 16:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-04 9:52 [pbs-devel] " Dominik Csapak
2022-02-04 16:18 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c5027b6f-19d3-9c3a-df6a-c19c2e5fde66@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.