Re: [pbs-devel] [PATCH proxmox-backup 1/9] cli: manager: move update-to-prune-jobs command to new migrate-config sub-command

[Thomas Lamprecht <t.lamprecht@proxmox.com>]

Am 23.06.25 um 16:13 schrieb Lukas Wagner:
> The new subcommand is introduced so that we have a common name space for
> any config migration tasks which are triggered by d/postinst (or potentially
> by hand).
> 
> No functional changes.
> 
> Signed-off-by: Lukas Wagner <l.wagner@proxmox.com>
> ---
> 
> Notes:
>     I guess at this point we could also drop this code entirely?
> 
>  debian/postinst                               |  2 +-
>  src/bin/proxmox-backup-manager.rs             |  6 +-
>  .../proxmox_backup_manager/migrate_config.rs  | 98 +++++++++++++++++++
>  src/bin/proxmox_backup_manager/mod.rs         |  1 +
>  src/bin/proxmox_backup_manager/prune.rs       | 87 +---------------
>  5 files changed, 104 insertions(+), 90 deletions(-)
>  create mode 100644 src/bin/proxmox_backup_manager/migrate_config.rs
> 
> diff --git a/debian/postinst b/debian/postinst
> index f38a8c66..7f4c57cc 100644
> --- a/debian/postinst
> +++ b/debian/postinst
> @@ -35,7 +35,7 @@ case "$1" in
>  
>  		if dpkg --compare-versions "$2" 'lt' '2.2.2~'; then

FWIW, this can actually be dropped for PBS 4, as we do not support upgrading from 2,
so this cannot be ever evaluate to true anymore there.


>  			echo "moving prune schedule from datacenter config to new prune job config"
> -			proxmox-backup-manager update-to-prune-jobs-config \
> +			proxmox-backup-manager migrate-config update-to-prune-jobs-config \
>  			    || echo "Failed to move prune jobs, please check manually"
>  			true
>  		fi


_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel