From: Gabriel Goller <g.goller@proxmox.com>
To: Thomas Lamprecht <t.lamprecht@proxmox.com>,
Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>, Fiona Ebner <f.ebner@proxmox.com>
Subject: Re: [pbs-devel] [PATCH proxmox-backup] api: make prune-group a real workertask
Date: Wed, 24 Jan 2024 14:42:21 +0100 [thread overview]
Message-ID: <c435c040-d6dc-450f-9703-b9668aacb14f@proxmox.com> (raw)
In-Reply-To: <79baa37c-654f-4b34-a5e9-ce5c64355433@proxmox.com>
On 24-01-2024 14:28, Thomas Lamprecht wrote:
> Am 24/01/2024 um 14:17 schrieb Fiona Ebner:
>> Am 24.01.24 um 11:34 schrieb Gabriel Goller:
>>> - Ok(json!(prune_result))
>>> + Ok(json!(upid))
>> That seems like a breaking API change at a first glance and thus has to
>> wait for the next major release unfortunately.
>>
>> AFAIU the same rules as for PVE apply, see:
>> https://pve.proxmox.com/wiki/Proxmox_VE_API#API_Stability_.26_Breakage
>>
> Yes, if applied strictly, and this here might be indeed a breakage that
> matters in practice.
>
> But you can work around that by making it use a worker task opt-in via
> a new parameter boolean flag.
Will do that.
> Oh, and isn't prune_result now unused? We're still lacking a simple
> and standardized method to save a structured result alongside a task
> UPID, otherwise it could be saved there, but that's another topic.
Hmm, yeah noticed that... I think I'll convert it to a structure and
pretty-print it to the task-log.
next prev parent reply other threads:[~2024-01-24 13:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-24 10:34 Gabriel Goller
2024-01-24 13:17 ` Fiona Ebner
2024-01-24 13:28 ` Thomas Lamprecht
2024-01-24 13:42 ` Gabriel Goller [this message]
2024-01-25 11:49 ` Gabriel Goller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c435c040-d6dc-450f-9703-b9668aacb14f@proxmox.com \
--to=g.goller@proxmox.com \
--cc=f.ebner@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
--cc=t.lamprecht@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.