From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Dominik Csapak <d.csapak@proxmox.com>
Subject: [pve-devel] applied: [PATCH manager v2 0/2] add UI support for editing metric servers
Date: Mon, 23 Nov 2020 07:11:38 +0100 [thread overview]
Message-ID: <c425ed14-9a3b-6b40-82ca-3b25d0ec7260@proxmox.com> (raw)
In-Reply-To: <20201120141228.24005-1-d.csapak@proxmox.com>
On 20.11.20 15:12, Dominik Csapak wrote:
> Adds the typical sectionconfig api entry points, as well as a basic
> CRUD ui under Datacenter -> Metric Server
>
> the next step is to adapt the documentation to no refer to editing the
> config anymore, adding some more useful information, as well
> as adding a onlinehelp link to the ui
>
> changes from v1:
> * integrated thomas feedback, aside from using createSchema for return values
> (i'll look at it soon)
> * ran eslint -f over dc/MetricServerView.js
>
> Dominik Csapak (2):
> api2/cluster: add 'metricserver' api endpoints
> ui: add MetricServerView to Datacenter
>
> PVE/API2/Cluster.pm | 7 +
> PVE/API2/Cluster/Makefile | 1 +
> PVE/API2/Cluster/MetricServerConfig.pm | 228 ++++++++++++++
> www/manager6/Makefile | 1 +
> www/manager6/dc/Config.js | 6 +
> www/manager6/dc/MetricServerView.js | 397 +++++++++++++++++++++++++
> 6 files changed, 640 insertions(+)
> create mode 100644 PVE/API2/Cluster/MetricServerConfig.pm
> create mode 100644 www/manager6/dc/MetricServerView.js
>
applied, thanks! I did followups for the remaining comments I had on v1 that
went lost.
prev parent reply other threads:[~2020-11-23 6:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-20 14:12 [pve-devel] " Dominik Csapak
2020-11-20 14:12 ` [pve-devel] [PATCH manager v2 1/2] api2/cluster: add 'metricserver' api endpoints Dominik Csapak
2020-11-20 14:12 ` [pve-devel] [PATCH manager v2 2/2] ui: add MetricServerView to Datacenter Dominik Csapak
2020-11-23 6:11 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c425ed14-9a3b-6b40-82ca-3b25d0ec7260@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.