all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
	Fiona Ebner <f.ebner@proxmox.com>
Subject: [pve-devel] superseded: [PATCH proxmox] apt: tests: remove output directories before running test
Date: Thu, 7 Sep 2023 10:30:00 +0200	[thread overview]
Message-ID: <c3fa1489-bc80-457a-aa41-ab54ecfa2b95@proxmox.com> (raw)
In-Reply-To: <20230605152646.178768-1-f.ebner@proxmox.com>

Am 05/06/2023 um 17:26 schrieb Fiona Ebner:
> I blindly assumed that cargo would re-create the TMPDIR before each
> test run, but that doesn't seem to be the case and the test_digest
> test now fails the second time when running 'cargo test' twice.
> 
> So partially revert 9b7c533 ("apt: tests: create temporary test
> directories in CARGO_TARGET_TMPDIR") and re-introduce the
> remove-before-test logic.
> 
> Fixes: 9b7c533 ("apt: tests: create temporary test directories in CARGO_TARGET_TMPDIR")
> Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
> ---
>  proxmox-apt/tests/repositories.rs | 10 ++++++++++
>  1 file changed, 10 insertions(+)

for the record, as we talked off-list:

I run into this my own and missed that there was already a patch on the list.

Thus I quick fixed it directly [0]: for the test case I run into, but you showed
my your patch and I then decided that we can factor that cleanup+create out and
did so with [1]. So this patch here should now be fully superseded.

[0]: https://git.proxmox.com/?p=proxmox.git;a=commitdiff;h=ae3c04a76b0b82597b63989e1a97ae919af03168
[1]: https://git.proxmox.com/?p=proxmox.git;a=commitdiff;h=4e2cc6fd53dec2b61d54e25b3e8b9b1fb0bf43d3




      reply	other threads:[~2023-09-07  8:30 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-05 15:26 [pve-devel] " Fiona Ebner
2023-09-07  8:30 ` Thomas Lamprecht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c3fa1489-bc80-457a-aa41-ab54ecfa2b95@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=f.ebner@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal