[pve-devel] [PATCH manager] ui: qemu/HDEdit: add 'aio' advanced option

[pve-devel] [PATCH manager] ui: qemu/HDEdit: add 'aio' advanced option

[Dominik Csapak]

so that users can change it more easily if necessary

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
the 'default' label is a bit too long, but was not sure if i should make
the default labelwidth shorter for all (i think we did this for a reason)
or if i should leave the 'io_uring' part out? any suggestions?


 www/manager6/qemu/HDEdit.js | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)

diff --git a/www/manager6/qemu/HDEdit.js b/www/manager6/qemu/HDEdit.js
index f5e2472f..7e470e39 100644
--- a/www/manager6/qemu/HDEdit.js
+++ b/www/manager6/qemu/HDEdit.js
@@ -92,6 +92,7 @@ Ext.define('PVE.qemu.HDInputPanel', {
 	PVE.Utils.propertyStringSet(me.drive, values.iothread, 'iothread', 'on');
 	PVE.Utils.propertyStringSet(me.drive, values.readOnly, 'ro', 'on');
 	PVE.Utils.propertyStringSet(me.drive, values.cache, 'cache');
+	PVE.Utils.propertyStringSet(me.drive, values.aio, 'aio');
 
 	['mbps_rd', 'mbps_wr', 'iops_rd', 'iops_wr'].forEach(name => {
 	    let burst_name = `${name}_max`;
@@ -151,6 +152,7 @@ Ext.define('PVE.qemu.HDInputPanel', {
 	values.ssd = PVE.Parser.parseBoolean(drive.ssd);
 	values.iothread = PVE.Parser.parseBoolean(drive.iothread);
 	values.readOnly = PVE.Parser.parseBoolean(drive.ro);
+	values.aio = drive.aio || '__default__';
 
 	values.mbps_rd = drive.mbps_rd;
 	values.mbps_wr = drive.mbps_wr;
@@ -307,6 +309,20 @@ Ext.define('PVE.qemu.HDInputPanel', {
 		labelWidth: labelWidth,
 		name: 'noreplicate',
 	    },
+	    {
+		xtype: 'proxmoxKVComboBox',
+		name: 'aio',
+		fieldLabel: gettext('Async IO'),
+		allowBlank: false,
+		value: '__default__',
+		labelWidth: labelWidth,
+		comboItems: [
+		    ['__default__', Proxmox.Utils.defaultText + ' (io_uring)'],
+		    ['io_uring', 'io_uring'],
+		    ['native', 'native'],
+		    ['threads', 'threads'],
+		],
+	    },
 	);
 
 	let bwColumn1 = [
-- 
2.30.2

[pve-devel] applied: [PATCH manager] ui: qemu/HDEdit: add 'aio' advanced option

[Thomas Lamprecht]

On 16.11.21 13:48, Dominik Csapak wrote:
> so that users can change it more easily if necessary
> 
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> the 'default' label is a bit too long, but was not sure if i should make
> the default labelwidth shorter for all (i think we did this for a reason)
> or if i should leave the 'io_uring' part out? any suggestions?
> 
> 
>  www/manager6/qemu/HDEdit.js | 16 ++++++++++++++++
>  1 file changed, 16 insertions(+)
> 
>

applied, thanks!