* [pmg-devel] [PATCH pmg-api/pmg-gui] align password length requirements with current recommendations @ 2025-02-26 12:30 Stoiko Ivanov 2025-02-26 12:30 ` [pmg-devel] [PATCH pmg-api 1/1] user config: password: unify length constraints and set minlength to 8 Stoiko Ivanov ` (2 more replies) 0 siblings, 3 replies; 5+ messages in thread From: Stoiko Ivanov @ 2025-02-26 12:30 UTC (permalink / raw) To: pmg-devel the patchset unifies the length requirments for passwords (minimum 8) one place where it's still not displayed as error is the change password window, as this comes from proxmox-widget-toolkit and I'm not sure if we have the requirements in the backend everywhere it is used. minimally tested in my setup. pmg-api: Stoiko Ivanov (1): user config: password: unify length constraints and set minlength to 8 src/PMG/API2/AccessControl.pm | 2 +- src/PMG/UserConfig.pm | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) pmg-gui: Stoiko Ivanov (1): user: create: set password minLength to 8 js/UserEdit.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.39.5 _______________________________________________ pmg-devel mailing list pmg-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pmg-devel ^ permalink raw reply [flat|nested] 5+ messages in thread
* [pmg-devel] [PATCH pmg-api 1/1] user config: password: unify length constraints and set minlength to 8 2025-02-26 12:30 [pmg-devel] [PATCH pmg-api/pmg-gui] align password length requirements with current recommendations Stoiko Ivanov @ 2025-02-26 12:30 ` Stoiko Ivanov 2025-02-26 12:53 ` [pmg-devel] applied: " Thomas Lamprecht 2025-02-26 12:30 ` [pmg-devel] [PATCH pmg-gui 1/1] user: create: set password minLength " Stoiko Ivanov 2025-02-26 12:55 ` [pmg-devel] [PATCH pmg-api/pmg-gui] align password length requirements with current recommendations Gabriel Goller 2 siblings, 1 reply; 5+ messages in thread From: Stoiko Ivanov @ 2025-02-26 12:30 UTC (permalink / raw) To: pmg-devel to be in line with the requirements from the newer ISO installers and our recommendations. Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com> --- src/PMG/API2/AccessControl.pm | 2 +- src/PMG/UserConfig.pm | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/PMG/API2/AccessControl.pm b/src/PMG/API2/AccessControl.pm index cf66c80..1e0d405 100644 --- a/src/PMG/API2/AccessControl.pm +++ b/src/PMG/API2/AccessControl.pm @@ -306,8 +306,8 @@ __PACKAGE__->register_method ({ password => { description => "The new password.", type => 'string', - minLength => 5, maxLength => 64, + minLength => 8, }, } }, diff --git a/src/PMG/UserConfig.pm b/src/PMG/UserConfig.pm index 9a6f142..cf12645 100644 --- a/src/PMG/UserConfig.pm +++ b/src/PMG/UserConfig.pm @@ -144,8 +144,8 @@ delete $create_schema->{properties}->{username}; $create_schema->{properties}->{password} = { description => "Password", type => 'string', - maxLength => 32, - minLength => 5, + maxLength => 64, + minLength => 8, optional => 1, }; -- 2.39.5 _______________________________________________ pmg-devel mailing list pmg-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pmg-devel ^ permalink raw reply [flat|nested] 5+ messages in thread
* [pmg-devel] applied: [PATCH pmg-api 1/1] user config: password: unify length constraints and set minlength to 8 2025-02-26 12:30 ` [pmg-devel] [PATCH pmg-api 1/1] user config: password: unify length constraints and set minlength to 8 Stoiko Ivanov @ 2025-02-26 12:53 ` Thomas Lamprecht 0 siblings, 0 replies; 5+ messages in thread From: Thomas Lamprecht @ 2025-02-26 12:53 UTC (permalink / raw) To: Stoiko Ivanov, pmg-devel Am 26.02.25 um 13:30 schrieb Stoiko Ivanov: > to be in line with the requirements from the newer ISO installers and > our recommendations. > > Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com> > --- > src/PMG/API2/AccessControl.pm | 2 +- > src/PMG/UserConfig.pm | 4 ++-- > 2 files changed, 3 insertions(+), 3 deletions(-) > > applied this one, for the UI I took the one from Maximiliano, thanks! _______________________________________________ pmg-devel mailing list pmg-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pmg-devel ^ permalink raw reply [flat|nested] 5+ messages in thread
* [pmg-devel] [PATCH pmg-gui 1/1] user: create: set password minLength to 8 2025-02-26 12:30 [pmg-devel] [PATCH pmg-api/pmg-gui] align password length requirements with current recommendations Stoiko Ivanov 2025-02-26 12:30 ` [pmg-devel] [PATCH pmg-api 1/1] user config: password: unify length constraints and set minlength to 8 Stoiko Ivanov @ 2025-02-26 12:30 ` Stoiko Ivanov 2025-02-26 12:55 ` [pmg-devel] [PATCH pmg-api/pmg-gui] align password length requirements with current recommendations Gabriel Goller 2 siblings, 0 replies; 5+ messages in thread From: Stoiko Ivanov @ 2025-02-26 12:30 UTC (permalink / raw) To: pmg-devel Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com> --- js/UserEdit.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/js/UserEdit.js b/js/UserEdit.js index bd94686..8c67312 100644 --- a/js/UserEdit.js +++ b/js/UserEdit.js @@ -47,7 +47,7 @@ Ext.define('PMG.UserEdit', { xtype: 'textfield', inputType: 'password', fieldLabel: gettext('Password'), - minLength: 5, + minLength: 8, allowBlank: false, name: 'password', listeners: { -- 2.39.5 _______________________________________________ pmg-devel mailing list pmg-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pmg-devel ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [pmg-devel] [PATCH pmg-api/pmg-gui] align password length requirements with current recommendations 2025-02-26 12:30 [pmg-devel] [PATCH pmg-api/pmg-gui] align password length requirements with current recommendations Stoiko Ivanov 2025-02-26 12:30 ` [pmg-devel] [PATCH pmg-api 1/1] user config: password: unify length constraints and set minlength to 8 Stoiko Ivanov 2025-02-26 12:30 ` [pmg-devel] [PATCH pmg-gui 1/1] user: create: set password minLength " Stoiko Ivanov @ 2025-02-26 12:55 ` Gabriel Goller 2 siblings, 0 replies; 5+ messages in thread From: Gabriel Goller @ 2025-02-26 12:55 UTC (permalink / raw) To: Stoiko Ivanov; +Cc: pmg-devel Consider: Tested-by: Gabriel Goller <g.goller@proxmox.com> _______________________________________________ pmg-devel mailing list pmg-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pmg-devel ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2025-02-26 12:55 UTC | newest] Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2025-02-26 12:30 [pmg-devel] [PATCH pmg-api/pmg-gui] align password length requirements with current recommendations Stoiko Ivanov 2025-02-26 12:30 ` [pmg-devel] [PATCH pmg-api 1/1] user config: password: unify length constraints and set minlength to 8 Stoiko Ivanov 2025-02-26 12:53 ` [pmg-devel] applied: " Thomas Lamprecht 2025-02-26 12:30 ` [pmg-devel] [PATCH pmg-gui 1/1] user: create: set password minLength " Stoiko Ivanov 2025-02-26 12:55 ` [pmg-devel] [PATCH pmg-api/pmg-gui] align password length requirements with current recommendations Gabriel Goller
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.Service provided by Proxmox Server Solutions GmbH | Privacy | Legal