[pbs-devel] [PATCH proxmox-backup] Remove mentioning rustup in README.rst because it's no longer needed

[pbs-devel] [PATCH proxmox-backup] Remove mentioning rustup in README.rst because it's no longer needed

[Laurențiu Leahu-Vlăducu]

Signed-off-by: Laurențiu Leahu-Vlăducu <l.leahu-vladucu@proxmox.com>
---
 README.rst | 9 ---------
 1 file changed, 9 deletions(-)

diff --git a/README.rst b/README.rst
index 0caa9874..1f1a66f2 100644
--- a/README.rst
+++ b/README.rst
@@ -2,15 +2,6 @@
 Build & Release Notes
 *********************
 
-``rustup`` Toolchain
-====================
-
-We normally want to build with the ``rustc`` Debian package. To do that
-you can set the following ``rustup`` configuration:
-
-    # rustup toolchain link system /usr
-    # rustup default system
-
 
 Versioning of proxmox helper crates
 ===================================
-- 
2.39.5


_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel

Re: [pbs-devel] [PATCH proxmox-backup] Remove mentioning rustup in README.rst because it's no longer needed

[Shannon Sterz]

On Fri Dec 13, 2024 at 2:50 PM CET, Laurențiu Leahu-Vlăducu wrote:
> Signed-off-by: Laurențiu Leahu-Vlăducu <l.leahu-vladucu@proxmox.com>
> ---
>  README.rst | 9 ---------
>  1 file changed, 9 deletions(-)
>
> diff --git a/README.rst b/README.rst
> index 0caa9874..1f1a66f2 100644
> --- a/README.rst
> +++ b/README.rst
> @@ -2,15 +2,6 @@
>  Build & Release Notes
>  *********************
>
> -``rustup`` Toolchain
> -====================
> -
> -We normally want to build with the ``rustc`` Debian package. To do that
> -you can set the following ``rustup`` configuration:
> -
> -    # rustup toolchain link system /usr
> -    # rustup default system
> -

hm not sure this is "no longer needed". the info is still good if you
want to use rustup for other reasons, e.g. for testing out nightly
features etc. so maybe leave this but re-phrase it with "if you want to
use rustup, you should use the rustc package Debian provides. to do..."
etc.

>
>  Versioning of proxmox helper crates
>  ===================================



_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel

Re: [pbs-devel] [PATCH proxmox-backup] Remove mentioning rustup in README.rst because it's no longer needed

[Laurențiu Leahu-Vlăducu]

On 16.12.24 10:16, Shannon Sterz wrote:
> On Fri Dec 13, 2024 at 2:50 PM CET, Laurențiu Leahu-Vlăducu wrote:
>> Signed-off-by: Laurențiu Leahu-Vlăducu <l.leahu-vladucu@proxmox.com>
>> ---
>>   README.rst | 9 ---------
>>   1 file changed, 9 deletions(-)
>>
>> diff --git a/README.rst b/README.rst
>> index 0caa9874..1f1a66f2 100644
>> --- a/README.rst
>> +++ b/README.rst
>> @@ -2,15 +2,6 @@
>>   Build & Release Notes
>>   *********************
>>
>> -``rustup`` Toolchain
>> -====================
>> -
>> -We normally want to build with the ``rustc`` Debian package. To do that
>> -you can set the following ``rustup`` configuration:
>> -
>> -    # rustup toolchain link system /usr
>> -    # rustup default system
>> -
> 
> hm not sure this is "no longer needed". the info is still good if you
> want to use rustup for other reasons, e.g. for testing out nightly
> features etc. so maybe leave this but re-phrase it with "if you want to
> use rustup, you should use the rustc package Debian provides. to do..."
> etc.

Agreed. I was under the impression that this part of README.rst is out 
of date, being written at a time where the Rust compiler has just been 
added to the Debian packages, where it might have been desirable to use 
rustup more (or very) often. But of course, you are right that there are 
still good reasons for using rustup, even nowadays. I will send a new 
patch that improves the description as you suggested. Thanks!

> 
>>
>>   Versioning of proxmox helper crates
>>   ===================================
> 



_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel