From: Dominik Csapak <d.csapak@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Markus Frank <m.frank@proxmox.com>
Subject: Re: [pve-devel] [PATCH qemu-server v10 1/4] add C program to get hardware capabilities from CPUID
Date: Fri, 17 May 2024 13:21:45 +0200 [thread overview]
Message-ID: <c212063c-b5a5-4ab7-874e-6e8e95269b9d@proxmox.com> (raw)
In-Reply-To: <20240510114706.990385-2-m.frank@proxmox.com>
one small nit inline:
On 5/10/24 13:47, Markus Frank wrote:
> diff --git a/query-machine-capabilities/Makefile b/query-machine-capabilities/Makefile
> new file mode 100644
> index 0000000..c5f6348
> --- /dev/null
> +++ b/query-machine-capabilities/Makefile
> @@ -0,0 +1,21 @@
> +DESTDIR=
> +PREFIX=/usr
> +SBINDIR=${PREFIX}/libexec/qemu-server
> +SERVICEDIR=/lib/systemd/system
> +
PREFIX is only used once here, so it's probably better inlining the value
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2024-05-17 11:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-10 11:47 [pve-devel] [PATCH qemu-server/docs/manager v10 0/4] AMD SEV Markus Frank
2024-05-10 11:47 ` [pve-devel] [PATCH qemu-server v10 1/4] add C program to get hardware capabilities from CPUID Markus Frank
2024-05-17 11:21 ` Dominik Csapak [this message]
2024-05-21 9:51 ` Thomas Lamprecht
2024-05-10 11:47 ` [pve-devel] [PATCH qemu-server v10 2/4] config: add AMD SEV support Markus Frank
2024-05-17 11:21 ` Dominik Csapak
2024-05-10 11:47 ` [pve-devel] [PATCH docs v10 3/4] add AMD SEV documentation Markus Frank
2024-05-10 11:47 ` [pve-devel] [PATCH manager v10 4/4] ui: add AMD SEV configuration to Options Markus Frank
2024-05-17 11:21 ` Dominik Csapak
2024-05-17 11:21 ` [pve-devel] [PATCH qemu-server/docs/manager v10 0/4] AMD SEV Dominik Csapak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c212063c-b5a5-4ab7-874e-6e8e95269b9d@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=m.frank@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.