From: Dominik Csapak <d.csapak@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Markus Frank <m.frank@proxmox.com>
Subject: Re: [pve-devel] [PATCH qemu-server/docs/manager v10 0/4] AMD SEV
Date: Fri, 17 May 2024 13:21:44 +0200 [thread overview]
Message-ID: <c2066d8d-63e9-49b4-ad20-b48b7a0b4484@proxmox.com> (raw)
In-Reply-To: <20240510114706.990385-1-m.frank@proxmox.com>
all in all the series looks mostly good to me with some minor comments
(see comments on the individual patches)
i could not test it since i don't have an amd epyc system here ;)
one high level thing though (but no hard feelings)
is the systemd service really necessary ?
we could simply call the binary the first time it's needed?
so in qemu-server:
---
if (! -e $cap_path) {
# executing the binary
}
---
before we try to parse it ?
we can still make it a service should we need, but IMHO this seems
overkill for the current use case
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2024-05-17 11:21 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-10 11:47 Markus Frank
2024-05-10 11:47 ` [pve-devel] [PATCH qemu-server v10 1/4] add C program to get hardware capabilities from CPUID Markus Frank
2024-05-17 11:21 ` Dominik Csapak
2024-05-21 9:51 ` Thomas Lamprecht
2024-05-10 11:47 ` [pve-devel] [PATCH qemu-server v10 2/4] config: add AMD SEV support Markus Frank
2024-05-17 11:21 ` Dominik Csapak
2024-05-10 11:47 ` [pve-devel] [PATCH docs v10 3/4] add AMD SEV documentation Markus Frank
2024-05-10 11:47 ` [pve-devel] [PATCH manager v10 4/4] ui: add AMD SEV configuration to Options Markus Frank
2024-05-17 11:21 ` Dominik Csapak
2024-05-17 11:21 ` Dominik Csapak [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c2066d8d-63e9-49b4-ad20-b48b7a0b4484@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=m.frank@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal