From: Christian Ebner <c.ebner@proxmox.com>
To: Hannes Laimer <h.laimer@proxmox.com>, pbs-devel@lists.proxmox.com
Subject: Re: [PATCH proxmox-backup v2] s3-client: fix Content-Type for put and copy object requests
Date: Tue, 17 Mar 2026 12:29:28 +0100 [thread overview]
Message-ID: <c1735f25-8de9-4452-ab14-8007210d85a1@proxmox.com> (raw)
In-Reply-To: <20260316141940.3576-1-h.laimer@proxmox.com>
On 3/16/26 3:19 PM, Hannes Laimer wrote:
> Use the IANA registered `application/octet-stream` content type instead
> of the non-standard `binary/octet` value in put_object.
>
> Also set Content-Type explicitly in copy_object requests, since some S3
> providers drop all source metadata, including Content-Type, when using
> x-amz-metadata-directive REPLACE unless it is explicitly provided. This
> caused s3_refresh to fail with "missing header 'content-type'" on such
> providers when fetching objects moved via copy_object.
>
> Setting it unconditionally is safe, since put_object already does the
> same.
>
> Signed-off-by: Hannes Laimer <h.laimer@proxmox.com>
Only one small nit: The header value "application/octet-stream" could
have been defined as common constant.
Tested by syncing new contents from a local datastore to an s3 datastore
backed by Ceph RGW and inspecting the content-type header value in the
ceph client logs. Further, moved a group with patches [0] applied again
checking the content-type header in the Ceph logs, performed a
successful s3-refresh and verification job on the group.
[0]
https://lore.proxmox.com/pbs-devel/c883656f-d89c-4e9d-97ab-3a47ee966200@proxmox.com/T/#t
Reviewed-by: Christian Ebner <c.ebner@proxmox.com>
Tested-by: Christian Ebner <c.ebner@proxmox.com>
prev parent reply other threads:[~2026-03-17 11:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-16 14:19 Hannes Laimer
2026-03-16 14:22 ` Hannes Laimer
2026-03-17 11:29 ` Christian Ebner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c1735f25-8de9-4452-ab14-8007210d85a1@proxmox.com \
--to=c.ebner@proxmox.com \
--cc=h.laimer@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.