* [pve-devel] [PATCH manager] ui: node options: make text for `wakeonlan` option a bit more descriptive
@ 2023-01-23 13:59 Lukas Wagner
2023-01-24 15:14 ` [pve-devel] applied: " Thomas Lamprecht
0 siblings, 1 reply; 2+ messages in thread
From: Lukas Wagner @ 2023-01-23 13:59 UTC (permalink / raw)
To: pve-devel
If one is not familiar with the underlying configuration option,
one might think that one can enable Wake-On-Lan for a node with this
option. It was not really clear (at least without RTFM ;) ) that a
MAC address is supposed to be entered here. The added text should
hopefully make this a bit more clear.
Also increased the label width a bit, so that a full MAC
address can be properly displayed.
Signed-off-by: Lukas Wagner <l.wagner@proxmox.com>
---
www/manager6/node/NodeOptionsView.js | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/www/manager6/node/NodeOptionsView.js b/www/manager6/node/NodeOptionsView.js
index b841b7b0..661c0e90 100644
--- a/www/manager6/node/NodeOptionsView.js
+++ b/www/manager6/node/NodeOptionsView.js
@@ -52,8 +52,9 @@ Ext.define('Proxmox.node.NodeOptionsView', {
{
xtype: 'text',
name: 'wakeonlan',
- text: gettext('Wake on LAN'),
+ text: gettext('MAC address for Wake on LAN'),
vtype: 'MacAddress',
+ labelWidth: 150,
deleteEmpty: true,
renderer: function(value) {
if (value === undefined) {
--
2.30.2
^ permalink raw reply [flat|nested] 2+ messages in thread
* [pve-devel] applied: [PATCH manager] ui: node options: make text for `wakeonlan` option a bit more descriptive
2023-01-23 13:59 [pve-devel] [PATCH manager] ui: node options: make text for `wakeonlan` option a bit more descriptive Lukas Wagner
@ 2023-01-24 15:14 ` Thomas Lamprecht
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Lamprecht @ 2023-01-24 15:14 UTC (permalink / raw)
To: Proxmox VE development discussion, Lukas Wagner
Am 23/01/2023 um 14:59 schrieb Lukas Wagner:
> If one is not familiar with the underlying configuration option,
> one might think that one can enable Wake-On-Lan for a node with this
> option. It was not really clear (at least without RTFM ;) ) that a
> MAC address is supposed to be entered here. The added text should
> hopefully make this a bit more clear.
>
> Also increased the label width a bit, so that a full MAC
> address can be properly displayed.
>
> Signed-off-by: Lukas Wagner <l.wagner@proxmox.com>
> ---
> www/manager6/node/NodeOptionsView.js | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
>
applied, thanks!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-01-24 15:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-23 13:59 [pve-devel] [PATCH manager] ui: node options: make text for `wakeonlan` option a bit more descriptive Lukas Wagner
2023-01-24 15:14 ` [pve-devel] applied: " Thomas Lamprecht
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal