From: Fiona Ebner <f.ebner@proxmox.com>
To: Dominik Csapak <d.csapak@proxmox.com>, pve-devel@lists.proxmox.com
Subject: Re: [PATCH qemu-server v3 1/2] pci: factor 'prepare_pci_devices' out to PVE::QemuServer::PCI module
Date: Mon, 24 Aug 2026 16:38:07 +0200 [thread overview]
Message-ID: <c125fff5-7282-40c8-91f6-16575825e9f4@proxmox.com> (raw)
In-Reply-To: <20260227120728.2152303-3-d.csapak@proxmox.com>
Am 27.02.26 um 1:08 PM schrieb Dominik Csapak:
> only slight change to the logic here was to return a uuid from an mdev
> in any case if we need it, and overwrite it in vm_start_nolock with
> the one from smbios1 if possible, instead of doing it the other way
> round.
>
> This was necessary since we don't have access to parse_smbios1 in the
> PCI module.
>
Could you split this change in two parts then, i.e. first the logic,
then the pure move?
Needs a rebase, I guess because of
4025df75 ("pci: move mdev related code to own module")
next prev parent reply other threads:[~2026-08-24 14:38 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-27 12:06 [PATCH docs/guest-common/qemu-server v3 0/4] add new pci passthrough specific hookscript phase Dominik Csapak
2026-02-27 12:06 ` [PATCH guest-common v3 1/1] helpers: exec hookscript: add optional parameters Dominik Csapak
2026-08-24 14:38 ` Fiona Ebner
2026-02-27 12:06 ` [PATCH qemu-server v3 1/2] pci: factor 'prepare_pci_devices' out to PVE::QemuServer::PCI module Dominik Csapak
2026-08-24 14:38 ` Fiona Ebner [this message]
2026-02-27 12:06 ` [PATCH qemu-server v3 2/2] pci: call hookscript for each prepared pci device Dominik Csapak
2026-08-24 14:38 ` Fiona Ebner
2026-02-27 12:06 ` [PATCH docs v3 1/1] examples: add new hookscript phase to example hookscript Dominik Csapak
2026-08-24 14:38 ` Fiona Ebner
2026-08-25 14:10 ` superseded: [PATCH docs/guest-common/qemu-server v3 0/4] add new pci passthrough specific hookscript phase Dominik Csapak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c125fff5-7282-40c8-91f6-16575825e9f4@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.