From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id CC5091FF0B2 for ; Mon, 24 Aug 2026 16:38:14 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id DB42621620; Mon, 24 Aug 2026 16:38:11 +0200 (CEST) Message-ID: Date: Mon, 24 Aug 2026 16:38:07 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH qemu-server v3 1/2] pci: factor 'prepare_pci_devices' out to PVE::QemuServer::PCI module To: Dominik Csapak , pve-devel@lists.proxmox.com References: <20260227120728.2152303-1-d.csapak@proxmox.com> <20260227120728.2152303-3-d.csapak@proxmox.com> Content-Language: en-US From: Fiona Ebner In-Reply-To: <20260227120728.2152303-3-d.csapak@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1787582257368 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.844 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: 4WHFG6B3JYUO2WZ2GT3PR6NXVTWHJ6R4 X-Message-ID-Hash: 4WHFG6B3JYUO2WZ2GT3PR6NXVTWHJ6R4 X-MailFrom: f.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Am 27.02.26 um 1:08 PM schrieb Dominik Csapak: > only slight change to the logic here was to return a uuid from an mdev > in any case if we need it, and overwrite it in vm_start_nolock with > the one from smbios1 if possible, instead of doing it the other way > round. > > This was necessary since we don't have access to parse_smbios1 in the > PCI module. > Could you split this change in two parts then, i.e. first the logic, then the pure move? Needs a rebase, I guess because of 4025df75 ("pci: move mdev related code to own module")