Re: [pve-devel] [PATCH proxmox_login_manager/pve_flutter_frontend 0/2] refactor: ui: add new settings page in `pve_flutter_frontend`

[Dominik Csapak <d.csapak@proxmox.com>]

changes look good to me

something I noticed (that's not your fault at all) which irks me a bit
is that we don't really have any dependency management between

proxmox_login_manager and pve_flutter_frontend

as in, we don't ever bump the version of proxmox_login_manager
(and the dart_api_client of course)

while most of the time it's not a problem i guess (as long
as the current master still builds), when we at one point
want to go back in time (e.g. for bisecting) we don't know anymore
which state the other repositories were (and have to guess)

Would it make sense to you to start using proper versioning for the
lower level repositories/packages? or is it possible
to track git revisions at least in the pubspec.yaml?
(that way we would just have to update the git revision
in pve_flutter_frontend)

if we now update the flutter app more regularly and with more
people, it may make sense to do this properly

I noticed now, because this is technically a breaking change between
the packages, and just applying one patch would break the other

what do you say?
@Thomas, do you have an opinion here?


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel