From: Gabriel Goller <g.goller@proxmox.com>
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>, Stefan Lendl <s.lendl@proxmox.com>
Subject: Re: [pbs-devel] [PATCH v2 proxmox-backup 0/3] datastore: Create a prune job upon datastore creation
Date: Wed, 22 Nov 2023 10:24:50 +0100 [thread overview]
Message-ID: <bfde30c4-428c-42c2-ac8b-ab93b520e029@proxmox.com> (raw)
In-Reply-To: <20231121162111.537833-1-s.lendl@proxmox.com>
LGTM!
Just one small clippy warning:
warning: using `Option.and_then(|x| Some(y))`, which is more succinctly
expressed as `map(|x| y)`
--> src/api2/config/datastore.rs:128:28
Otherwise you can consider:
Tested-by: Gabriel Goller <g.goller@proxmox.com>
next prev parent reply other threads:[~2023-11-22 9:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-21 16:21 Stefan Lendl
2023-11-21 16:21 ` [pbs-devel] [PATCH v2 proxmox-backup 1/3] prune job: prune job creation in separate function Stefan Lendl
2023-11-21 16:21 ` [pbs-devel] [PATCH v2 proxmox-backup 2/3] pass worker context to do_create_prune_job Stefan Lendl
2023-11-21 16:21 ` [pbs-devel] [PATCH v2 proxmox-backup 3/3] fix #4374: create a prune job upon datastore creation Stefan Lendl
2023-11-22 9:24 ` Gabriel Goller [this message]
2023-11-23 17:03 ` [pbs-devel] [PATCH v2 proxmox-backup 0/3] datastore: Create " Stefan Lendl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bfde30c4-428c-42c2-ac8b-ab93b520e029@proxmox.com \
--to=g.goller@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
--cc=s.lendl@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal