From: Aaron Lauterer <a.lauterer@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Maximiliano Sandoval <m.sandoval@proxmox.com>
Subject: Re: [pve-devel] [PATCH manager] ui: allow decompressing ISO compressed with bz2
Date: Thu, 7 Nov 2024 11:40:04 +0100 [thread overview]
Message-ID: <bf7f4335-c344-442b-ba5b-d48ca6de856f@proxmox.com> (raw)
In-Reply-To: <20240802143736.172810-1-m.sandoval@proxmox.com>
Tested in combination with the adjacent backend patch [0] by Downloading
a bz2 compressed ISO and booting a VM from it.
One small style nit inline, but I don't think that warants a new
version, as we can fix it in a follow up or just directly when applying
the patch.
[0]
https://lore.proxmox.com/pve-devel/d92e4078-00bf-48ad-9be8-afaeaf7398be@proxmox.com/T/#m6cff68830fd5356ebddfff8cee7f4b8c7d7770bd
Tested-By: Aaron Lauterer <a.lauterer@proxmox.com>
Reviewed-By: Aaron Lauterer <a.lauterer@proxmox.com>
On 2024-08-02 16:37, Maximiliano Sandoval wrote:
> Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
> ---
>
> This is a follow-up of the patch:
>
> [PATCH storage] storage: add bzip2 support
>
> which can be found at [1].
>
> [1] https://lists.proxmox.com/pipermail/pve-devel/2024-August/065030.html
>
>
> www/manager6/window/DownloadUrlToStorage.js | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/www/manager6/window/DownloadUrlToStorage.js b/www/manager6/window/DownloadUrlToStorage.js
> index 5523a152..9cd44d5c 100644
> --- a/www/manager6/window/DownloadUrlToStorage.js
> +++ b/www/manager6/window/DownloadUrlToStorage.js
> @@ -84,7 +84,7 @@ Ext.define('PVE.window.DownloadUrlToStorage', {
> let filename = data.filename || "";
> let compression = '__default__';
> if (view.content === 'iso') {
> - const matches = filename.match(/^(.+)\.(gz|lzo|zst)$/i);
> + const matches = filename.match(/^(.+)\.(gz|lzo|zst|bz2)$/i);
> if (matches) {
> filename = matches[1];
> compression = matches[2].toLowerCase();
> @@ -228,6 +228,7 @@ Ext.define('PVE.window.DownloadUrlToStorage', {
> ['lzo', 'LZO'],
> ['gz', 'GZIP'],
> ['zst', 'ZSTD'],
> + ['bz2', 'bzip2'],
All the other options in the list are all-caps. We probably want this
also to be BZIP2 to not break the overall theme here.
> ],
> cbind: {
> hidden: get => get('content') !== 'iso',
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2024-11-07 10:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-02 14:37 Maximiliano Sandoval
2024-11-07 10:40 ` Aaron Lauterer [this message]
2024-11-11 9:39 ` [pve-devel] applied: " Fabian Grünbichler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bf7f4335-c344-442b-ba5b-d48ca6de856f@proxmox.com \
--to=a.lauterer@proxmox.com \
--cc=m.sandoval@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.