From: Christian Ebner <c.ebner@proxmox.com>
To: "Michael Köppl" <m.koeppl@proxmox.com>, pbs-devel@lists.proxmox.com
Subject: Re: [PATCH proxmox-backup v1 1/2] fix #7400: api: gracefully handle corrupted job statefiles
Date: Wed, 18 Mar 2026 17:15:00 +0100 [thread overview]
Message-ID: <bedf61c6-0576-4a05-944c-9cbe0b256958@proxmox.com> (raw)
In-Reply-To: <20260317160722.201693-2-m.koeppl@proxmox.com>
On 3/17/26 5:07 PM, Michael Köppl wrote:
> Previously, if a job statefile was empty or corrupted (e.g. due to an
> I/O error or an abrupt shutdown), the JobStatus::load method would
> return an error that would be propagated up, causing the endpoint to
> return an error to the user, meaning users would not see any of their
> jobs if a single job had a corrupted statefile.
>
> Instead, handle the error explicitly, logging a warning and returning a
> default JobScheduleStatus, such that jobs lists can still be fetched,
> displaying the affected job as configured but simply missing its last
> run status.
>
> Signed-off-by: Michael Köppl <m.koeppl@proxmox.com>
> ---
Thanks for the patches, one comment for this patch.
Instead of adapting all the call sides, loading of the state file might
be moved to compute_schedule_status() in a preparatory patch, passing
the job type and id as parameters. The improved error handling can then
be done inside that helper.
next prev parent reply other threads:[~2026-03-18 16:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-17 16:07 [PATCH proxmox-backup v1 0/2] fix #7400: improve handling of " Michael Köppl
2026-03-17 16:07 ` [PATCH proxmox-backup v1 1/2] fix #7400: api: gracefully handle " Michael Köppl
2026-03-18 16:15 ` Christian Ebner [this message]
2026-03-18 17:04 ` Michael Köppl
2026-03-18 17:22 ` Michael Köppl
2026-03-17 16:07 ` [PATCH proxmox-backup v1 2/2] fix #7400: proxy: self-heal " Michael Köppl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bedf61c6-0576-4a05-944c-9cbe0b256958@proxmox.com \
--to=c.ebner@proxmox.com \
--cc=m.koeppl@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.