all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
	Alexandre Derumier <aderumier@odiso.com>,
	Dietmar Maurer <dietmar@proxmox.com>
Subject: Re: [pve-devel] [PATCH pve-manager] pvestatd: stream host pressure counters
Date: Sat, 24 Oct 2020 17:43:23 +0200	[thread overview]
Message-ID: <bec21b42-05fe-a3c3-a7ec-e2a53a6887aa@proxmox.com> (raw)
In-Reply-To: <CAMGxVzAqdVyYZ4-1vOvfmVtAcmZtPs1fVzo7XH2EXCxLDGb5zw@mail.gmail.com>

On 24.10.20 15:46, Alexandre Derumier wrote:
>> Sounds reasonable. We just need to find a way to add new values
>> in a compatible way.
> 
> Last time in 2013, we had added a new rrd "pve2.3-vm/"
> https://lists.proxmox.com/pipermail/pve-devel/2013-January/005612.html

that'd drop all old statistics, and be a bit of a nuisance to upgrade inside
a cluster (old nodes get stuff they do not comprehend).

We may rather want to have a new, separate, file for this.
We could add general support for and error handling now, and to the final add
with 7.0 next year or so. Maybe there's even a way to add it now without other
nodes producing errors, but from top of my head I am not sure..

In Proxmox Backup Server we have each metric in a separate file, makes it a bit
easier to extend on.

# ls -l /var/lib/proxmox-backup/rrdb/host/
total 160
-rw-r--r-- 1 backup backup 6008 Oct 23 07:45 cpu
-rw-r--r-- 1 backup backup 6008 Oct 23 07:45 io_ticks
-rw-r--r-- 1 backup backup 6008 Oct 23 07:45 iowait
-rw-r--r-- 1 backup backup 6008 Oct 23 07:45 loadavg
-rw-r--r-- 1 backup backup 6008 Oct 23 07:45 memtotal
-rw-r--r-- 1 backup backup 6008 Oct 23 07:45 memused
-rw-r--r-- 1 backup backup 6008 Oct 23 07:45 netin
-rw-r--r-- 1 backup backup 6008 Oct 23 07:45 netout
-rw-r--r-- 1 backup backup 6008 Oct 23 07:45 read_bytes
-rw-r--r-- 1 backup backup 6008 Oct 23 07:45 read_ios
-rw-r--r-- 1 backup backup 6008 Jun  4 18:03 read_ticks
-rw-r--r-- 1 backup backup 6008 May 28 13:00 roottotal
-rw-r--r-- 1 backup backup 6008 May 28 13:00 rootused
-rw-r--r-- 1 backup backup 6008 Oct 23 07:45 swaptotal
-rw-r--r-- 1 backup backup 6008 Oct 23 07:45 swapused
-rw-r--r-- 1 backup backup 6008 Oct 23 07:45 total
-rw-r--r-- 1 backup backup 6008 Oct 23 07:45 used
-rw-r--r-- 1 backup backup 6008 Oct 23 07:45 write_bytes
-rw-r--r-- 1 backup backup 6008 Oct 23 07:45 write_ios
-rw-r--r-- 1 backup backup 6008 Jun  4 18:03 write_ticks


We could say we keep the base stuff as is in a single file and add
the new one with a "<vmid>.<metric-name>" scheme.





  reply	other threads:[~2020-10-24 15:43 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-06 11:58 Alexandre Derumier
2020-10-13  5:57 ` Dietmar Maurer
2020-10-22 23:53   ` Alexandre Derumier
2020-10-23  7:50     ` Dietmar Maurer
2020-10-24 13:46       ` Alexandre Derumier
2020-10-24 15:43         ` Thomas Lamprecht [this message]
2020-10-26  7:55           ` Alexandre Derumier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bec21b42-05fe-a3c3-a7ec-e2a53a6887aa@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=aderumier@odiso.com \
    --cc=dietmar@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal