Re: [pve-devel] [PATCH v3 widget-toolkit 1/2] repo view: replace non-clickable checkbox with icons

[Dominik Csapak <d.csapak@proxmox.com>]

On 1/26/23 11:47, Lukas Wagner wrote:
>  From a usability view, having a checkbox that is not clickable is pretty
> misleading, especially if the visual style is exactly the same as in
> other places in the UI where the checkbox is functional.
> 
> Signed-off-by: Lukas Wagner <l.wagner@proxmox.com>
> ---
>   src/Utils.js                | 2 ++
>   src/node/APTRepositories.js | 6 ++----
>   2 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/src/Utils.js b/src/Utils.js
> index ef0c2b8..a6dd314 100644
> --- a/src/Utils.js
> +++ b/src/Utils.js
> @@ -100,6 +100,8 @@ utilities: {
>   	return value;
>       },
>   
> +    renderEnabledIcon: enabled => `<i class="fa fa-${enabled ? 'check' : 'minus'}"></i>`,
> +

i know i'm a bit late to the party, but couldn't we simply show nothing when a repo is not enabled?
it's greyed-out anyway (though i'm not opposed to using the 'minus' icon here either)