Re: [pbs-devel] [PATCH proxmox-backup] fix: ui: spinner position

[Dominik Csapak <d.csapak@proxmox.com>]

On 9/13/23 16:20, Gabriel Goller wrote:
> When displaying the status of a job (sync, gc, etc..) the 'OK'
> and 'Error' text uses a padding of 10px to the left. The
> loading spinner is centered in the cell though. This doesn't
> look that good.

this is debatable, and having the 'loading' state stand out, makes sense imo.

*if* we want to change this, we either would have to adapt pve/pmg as well,
or refactor the class into the widget-toolkit (idk if there are some differences
across products, though it shouldn't be), because we also use that for the task
and job status list (e.g. replication)

> 
> Signed-off-by: Gabriel Goller <g.goller@proxmox.com>
> ---
>   www/css/ext6-pbs.css | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/www/css/ext6-pbs.css b/www/css/ext6-pbs.css
> index 5fd65d25..4a4a41be 100644
> --- a/www/css/ext6-pbs.css
> +++ b/www/css/ext6-pbs.css
> @@ -81,7 +81,7 @@
>   
>   /* loading in task list */
>   .x-grid-row-loading {
> -    background: no-repeat center center;
> +    background: no-repeat left 10px center;
>       background-image:url(../extjs/theme-crisp/resources/images/loadmask/loading.gif);
>   }
>