From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Gabriel Goller <g.goller@proxmox.com>
Subject: [pve-devel] applied: [PATCH container v4 3/3] api: return all addresses of an interface
Date: Mon, 7 Apr 2025 19:55:42 +0200 [thread overview]
Message-ID: <bbc59ae4-e552-4e2f-9bb3-8b4e47bd6cb1@proxmox.com> (raw)
In-Reply-To: <20250108143812.241488-4-g.goller@proxmox.com>
Am 08.01.25 um 15:38 schrieb Gabriel Goller:
> Return all ip-addresses of an interface, not only the first one. Change
> return schema to resemble the 'agent/network-get-interfaces' qemu call
> reponse. This helps us making the AgentIPView more generic and display
> the ip on both containers and vms.
> Preserve old attributes so that we remain backwards-compatible. These
> should be removed in the next version.
>
> Fixes: #5339
> Cc: Johannes Draaijer <jcdra1@gmail.com>
> Signed-off-by: Gabriel Goller <g.goller@proxmox.com>
> ---
> src/PVE/API2/LXC.pm | 37 +++++++++++++++++++++++++++++++++++--
> src/PVE/LXC.pm | 15 +++++++++++++++
> 2 files changed, 50 insertions(+), 2 deletions(-)
>
>
applied this one for now, with some small follow-ups for code style nits, thanks!
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2025-04-07 17:55 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-08 14:38 [pve-devel] [PATCH container/manager v4 0/3] Show container ip in summary and network tab Gabriel Goller
2025-01-08 14:38 ` [pve-devel] [PATCH manager v4 1/3] lxc: show dynamically assigned IPs in " Gabriel Goller
2025-04-07 17:46 ` Thomas Lamprecht
2025-04-08 10:06 ` Gabriel Goller
2025-04-08 10:18 ` Thomas Lamprecht
2025-04-08 11:27 ` Gabriel Goller
2025-04-08 11:30 ` Thomas Lamprecht
2025-04-08 12:15 ` Gabriel Goller
2025-04-08 12:20 ` Thomas Lamprecht
2025-01-08 14:38 ` [pve-devel] [PATCH manager v4 2/3] guest: refactor and reuse AgentIPView for containers Gabriel Goller
2025-01-08 14:38 ` [pve-devel] [PATCH container v4 3/3] api: return all addresses of an interface Gabriel Goller
2025-04-07 17:55 ` Thomas Lamprecht [this message]
2025-01-08 15:58 ` [pve-devel] [PATCH container/manager v4 0/3] Show container ip in summary and network tab Daniel Herzig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bbc59ae4-e552-4e2f-9bb3-8b4e47bd6cb1@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=g.goller@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal