all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
	Fiona Ebner <f.ebner@proxmox.com>
Subject: [pve-devel] applied: [PATCH qemu-server v2 4/8] cpu config: introduce vendor-agnostic 'nested-virt' CPU flag
Date: Fri, 14 Nov 2025 16:07:42 +0100	[thread overview]
Message-ID: <bb2cb1f5-377d-486f-b470-952eb3c40331@proxmox.com> (raw)
In-Reply-To: <20251107144429.126790-5-f.ebner@proxmox.com>

Am 07.11.25 um 15:44 schrieb Fiona Ebner:
> The flag will automatically resolve to the flag required for the
> current CPU on the host. The 'nested-virt' flag takes precendence over
> the CPU-specific flag for nesting which might already be present with
> custom CPU models. In that case, a warning is printed.
> 
> Also make sure that the actual resolved flag is passed along during
> live migration, since the nested-virt flag can resolve differently on
> different hosts.
> 
> Suggested-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
> Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
> ---
> 
> Changes in v2:
> * Pass running CPU configuration when using 'nested-virt'. This
>   ensures that migration fails early if the flag resolves differently
>   on the target.
> * Describe that live migration still only works if it's the same flag.
> 
> I was thinking about using special characters in the flag name or some
> custom-/pve-/special- prefix to distinguish from regular flags, but
> decided against it in the end, because I got the gut feeling it might
> cause more confusion than it helps. Users who are interested in
> details will hopefully read the description and for others, having the
> flag name be direct and descriptive is better.
> 
>  src/PVE/QemuServer/CPUConfig.pm | 52 +++++++++++++++++++++++++++++++--
>  1 file changed, 49 insertions(+), 3 deletions(-)
> 
>

Thanks for your follow-up mail, I tested again with EPYX-v4 vCPU for matching
the AMD EPYC 9475F in my test server and it worked well. Now the virtualization
flag also shows up for the CPU inside the guest from Windows POV, e.g. when
checking in the task managers (CTRL+SHIT+ESC) performance tab.

I amended the commit message with a note for the cpu model, getting some docs
might be nice, especially adapting our nested-virt guide in the wiki with
that info.

applied, thanks!


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


  reply	other threads:[~2025-11-14 15:07 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-07 14:43 [pve-devel] [PATCH-SERIES qemu-server/manager v2 0/8] VM CPU flags: " Fiona Ebner
2025-11-07 14:43 ` [pve-devel] [PATCH qemu-server v2 1/8] critic: code style: cpu config: unpack @_ first in resolve_cpu_flags() Fiona Ebner
2025-11-07 14:43 ` [pve-devel] [PATCH qemu-server v2 2/8] api: add endpoint for querying available cpu flags Fiona Ebner
2025-11-07 14:43 ` [pve-devel] [PATCH qemu-server v2 3/8] cpu config: introduce is_abstracted() helper Fiona Ebner
2025-11-07 14:43 ` [pve-devel] [PATCH qemu-server v2 4/8] cpu config: introduce vendor-agnostic 'nested-virt' CPU flag Fiona Ebner
2025-11-14 15:07   ` Thomas Lamprecht [this message]
2025-11-07 14:43 ` [pve-devel] [PATCH manager v2 5/8] api: capabilities: register module for VM CPU flags Fiona Ebner
2025-11-14  0:14   ` Thomas Lamprecht
2025-11-07 14:43 ` [pve-devel] [PATCH manager v2 6/8] ui: cpu flag selector: code style: use 'let' for declarations Fiona Ebner
2025-11-14  0:14   ` Thomas Lamprecht
2025-11-07 14:43 ` [pve-devel] [PATCH manager v2 7/8] ui: cpu flag selector: use simpler method to get all records of the store Fiona Ebner
2025-11-14  0:14   ` Thomas Lamprecht
2025-11-07 14:43 ` [pve-devel] [PATCH manager v2 8/8] ui: cpu flag selector: query CPU flag list via API Fiona Ebner
2025-11-14  0:14   ` Thomas Lamprecht
2025-11-10  9:47 ` [pve-devel] [PATCH-SERIES qemu-server/manager v2 0/8] VM CPU flags: introduce vendor-agnostic 'nested-virt' CPU flag Daniel Kral
2025-11-13 22:51 ` [pve-devel] partially-applied: " Thomas Lamprecht
2025-11-14 14:27   ` Fiona Ebner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bb2cb1f5-377d-486f-b470-952eb3c40331@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=f.ebner@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal