From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Christoph Heiss <c.heiss@proxmox.com>
Subject: [pve-devel] applied: [PATCH access-control] api: domains: fix setting only the realm authentication password
Date: Fri, 21 Jul 2023 16:14:17 +0200 [thread overview]
Message-ID: <baf72302-4dac-43b9-90f3-ff46ed4defbc@proxmox.com> (raw)
In-Reply-To: <20230720145000.418783-3-c.heiss@proxmox.com>
On 20/07/2023 16:48, Christoph Heiss wrote:
> Previously, if one tried to only update e.g. the bind password for an
> LDAP realm, it would fail with an rather unhelpful error message:
>
> # pveum realm modify ldap -password foo
> update auth server failed: no options specified
>
> The root cause was that the `password` parameter was removed early from
> the parameter object, which than would fail the check whether it is
> empty or not.
>
> Thus, additionally check if only `password` was specified and if so,
> allow it.
>
> Reported-by: Friedrich Weber <f.weber@proxmox.com>
> Signed-off-by: Christoph Heiss <c.heiss@proxmox.com>
> ---
> src/PVE/API2/Domains.pm | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
>
applied, thanks!
prev parent reply other threads:[~2023-07-21 14:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-20 14:48 [pve-devel] " Christoph Heiss
2023-07-21 14:14 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=baf72302-4dac-43b9-90f3-ff46ed4defbc@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=c.heiss@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal