all lists on lists.proxmox.com
 help / color / mirror / Atom feed
* Re: [pve-devel] [RFC] CentOS, Rocky, Alma 10
       [not found] <CADbnQj4SkX=D+zBN0oMEr1g+K0+oooEU1YWnH5PF-f5vH0NNeQ@mail.gmail.com>
@ 2025-09-10 20:46 ` Thomas Lamprecht
  0 siblings, 0 replies; 2+ messages in thread
From: Thomas Lamprecht @ 2025-09-10 20:46 UTC (permalink / raw)
  To: Peter, pve-devel

Am 10.09.25 um 22:04 schrieb Peter:
> After seeing the thread on Debian 13.1, I wanted to ask what the process is
> for adding container support for version 10 of the various RHEL families?
 
Sometimes it's enough to bump the accepted upper version limit, but that
won't cut it for the RHEL 10 based derivatives, as there the support for
the network configuration in the ifcfg format we previously used for RHEL
family got removed.

FWIW there is a patch series that includes the required changes [0], I
started review and had some local clean ups on top in prepared but not
yet fully finished. If you, or someone else, can test the mentioned series
it should help to accelerate things a bit.

[0]: https://lore.proxmox.com/all/mailman.338.1755988247.385.pve-devel@lists.proxmox.com/

> As to the mechanics, similar to Trixie, there's a version check that blocks
> installing a container running el10:
> 
> --- LXC/Setup/CentOS.pm.orig 2025-09-10 15:57:05.961409961 -0400
> 
> +++ LXC/Setup/CentOS.pm 2025-09-06 16:22:18.589570360 -0400
> 
> @@ -23,5 +23,5 @@
> 
> 
> 
>      if (($release =~ m/release\s+(\d+\.\d+)(\.\d+)?/) || ($release =~
> m/release\s+(\d+)/)) {
> 
> -        if ($1 >= 5 && $1 < 10) {
> 
> +        if ($1 >= 5 && $1 < 11) {
> 
>              $version = $1;
> 
>          }
> 
> That lets me install version 10, but then I get a warning each time the
> container starts.  It turns out the pattern matching for systemd version is
> a little too strict in LXC/Setup/Base.pm:get_systemd_version:
> 
>             if ($line =~
> /libsystemd-shared-(\d+)(?:[-.][a-zA-Z0-9]+)*\.so:?$/) {
> 
> This worked fine for version 9 and earlier, as their .so line looked like
> "libsystemd-shared-256.so".  But as of version 10, the .so line is now "
> libsystemd-shared-257-9.0.1.el10_0.1.so".  The "el10_0" throws off the
> regular expression.
> 
> Would it be preferable to loosen the pattern in Base.pm or to copy
> get_systemd_version into CentOS.pm and revise the pattern there?

The aforementioned series also addresses this, that patch got already
applied IIRC:

https://lore.proxmox.com/all/mailman.334.1755988211.385.pve-devel@lists.proxmox.com/


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


^ permalink raw reply	[flat|nested] 2+ messages in thread

* [pve-devel] [RFC] CentOS, Rocky, Alma 10
@ 2025-09-10 20:04 Peter via pve-devel
  0 siblings, 0 replies; 2+ messages in thread
From: Peter via pve-devel @ 2025-09-10 20:04 UTC (permalink / raw)
  To: pve-devel; +Cc: Peter

[-- Attachment #1: Type: message/rfc822, Size: 6592 bytes --]

From: Peter <pjcreath+proxmox@gmail.com>
To: pve-devel@lists.proxmox.com
Subject: [RFC] CentOS, Rocky, Alma 10
Date: Wed, 10 Sep 2025 16:04:43 -0400
Message-ID: <CADbnQj4SkX=D+zBN0oMEr1g+K0+oooEU1YWnH5PF-f5vH0NNeQ@mail.gmail.com>

After seeing the thread on Debian 13.1, I wanted to ask what the process is
for adding container support for version 10 of the various RHEL families?

As to the mechanics, similar to Trixie, there's a version check that blocks
installing a container running el10:

--- LXC/Setup/CentOS.pm.orig 2025-09-10 15:57:05.961409961 -0400

+++ LXC/Setup/CentOS.pm 2025-09-06 16:22:18.589570360 -0400

@@ -23,5 +23,5 @@



     if (($release =~ m/release\s+(\d+\.\d+)(\.\d+)?/) || ($release =~
m/release\s+(\d+)/)) {

-        if ($1 >= 5 && $1 < 10) {

+        if ($1 >= 5 && $1 < 11) {

             $version = $1;

         }

That lets me install version 10, but then I get a warning each time the
container starts.  It turns out the pattern matching for systemd version is
a little too strict in LXC/Setup/Base.pm:get_systemd_version:

            if ($line =~
/libsystemd-shared-(\d+)(?:[-.][a-zA-Z0-9]+)*\.so:?$/) {

This worked fine for version 9 and earlier, as their .so line looked like
"libsystemd-shared-256.so".  But as of version 10, the .so line is now "
libsystemd-shared-257-9.0.1.el10_0.1.so".  The "el10_0" throws off the
regular expression.

Would it be preferable to loosen the pattern in Base.pm or to copy
get_systemd_version into CentOS.pm and revise the pattern there?

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2025-09-10 20:46 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <CADbnQj4SkX=D+zBN0oMEr1g+K0+oooEU1YWnH5PF-f5vH0NNeQ@mail.gmail.com>
2025-09-10 20:46 ` [pve-devel] [RFC] CentOS, Rocky, Alma 10 Thomas Lamprecht
2025-09-10 20:04 Peter via pve-devel

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal