Re: [pve-devel] [PATCH proxmox 01/19] notify: switch to file-based templating system

[Fiona Ebner <f.ebner@proxmox.com>]

Am 19.04.24 um 10:45 schrieb Lukas Wagner:
>> Who adds the template files? I don't see a patch for proxmox-ve in this
>> series. Does this series require some versioned breaks to some package?
> 
> The pve-manager and pve-ha-manager (for fencing notifications) patches add the templates.
> I can't use `/usr/share/pve-manager` and `/usr/share/pve-ha-manager` because 
> proxmox_notify needs to have a single base directory from where to load template files.
> Maybe we should use some other base dir to avoid confusion with the `proxmox-ve` metapackage?
> 

Ah, I see. Yes, maybe a directory named based on libpve-notify-perl
would be better or proxmox-notify (but would need to be a bit careful
with co-installed PBS and PVE to not create accidental conflicts).

> In terms of versions:
> pve-{ha}-manager needs to pull in a bumped libpve-notify-perl
> libpve-notify-perl needs to pull in bumped libpve-rs-perl/libproxmox-rs-perl
> libpve-rs-perl needs to pull in bumped librust-proxmox-notify
> 
> I really wish the dep-chain was a bit easier, yet here we are.
> 

But there also is a need for versioned breaks, right? Because installing
new libpve-notify-perl (using new proxmox-perl-rs using new
proxmox-notify) without also upgrading pve-manager and pve-ha-manager
will be broken or am I missing something?


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel