From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>,
Maximiliano Sandoval R <m.sandoval@proxmox.com>
Subject: Re: [pbs-devel] [RFC proxmox-backup 1/2] datastore: Allow encoding with a set compression level
Date: Fri, 3 Nov 2023 21:01:52 +0100 [thread overview]
Message-ID: <ba7179f0-49e5-4b3c-9960-9d1b634b8c8d@proxmox.com> (raw)
In-Reply-To: <20231103151707.191010-1-m.sandoval@proxmox.com>
On 03/11/2023 16:17, Maximiliano Sandoval R wrote:
> We replace the boolean flag with an enum.
>
so what levels did you test (with what test cases), which difference
in size was seen, any runtime impacts ...?
For such thing's I really want to have at least *some* info about
such basic questions, which everyone will (or at least, should) ask
when seeing such a change, encoded in the commit message.
Something like that could also the basis of an argument for a (future)
change of the default level to 3 or so, maybe that's a better trade-off
than the current default.
next prev parent reply other threads:[~2023-11-03 20:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-03 15:17 Maximiliano Sandoval R
2023-11-03 15:17 ` [pbs-devel] [RFC proxmox-backup 2/2] client: add --compresion flag to create_backup Maximiliano Sandoval R
2023-11-03 20:01 ` Thomas Lamprecht [this message]
2023-11-06 10:12 ` [pbs-devel] [RFC proxmox-backup 1/2] datastore: Allow encoding with a set compression level Maximiliano Sandoval
2023-11-06 10:36 ` Christian Ebner
2023-11-06 10:56 ` Maximiliano Sandoval
2023-11-06 11:14 ` Dietmar Maurer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ba7179f0-49e5-4b3c-9960-9d1b634b8c8d@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=m.sandoval@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.