From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Stoiko Ivanov <s.ivanov@proxmox.com>
Subject: [pve-devel] applied-series: [PATCH storage 0/2] LIO: fix tainted config and minor cleanup
Date: Tue, 13 Oct 2020 11:15:43 +0200 [thread overview]
Message-ID: <ba6ae54b-6eef-3ca3-438f-45fbb1057889@proxmox.com> (raw)
In-Reply-To: <20201012153458.18685-1-s.ivanov@proxmox.com>
On 12.10.20 17:34, Stoiko Ivanov wrote:
>
> This patchset follows the fix in 609f117ff24d2cff6b155e1d4b1175ceebe5bd7b.
> Since several operations rely on values read from the remote target's
> LIO config (which is tainted), this patchset untaints the settings, which are
> actually needed (and stores only those), while reading the config.
>
> The second patch removes two small left-over statements, which confused me
> while debugging.
>
> Tested very roughly (adding disks, create/rollback snapshot, remove disk) on
> a VM backed by a LIO-iSCSI target.
>
> Stoiko Ivanov (2):
> LIO: untaint values read from remote config
> LIO: drop unused statements
>
> PVE/Storage/LunCmd/LIO.pm | 21 ++++++++++++++++-----
> 1 file changed, 16 insertions(+), 5 deletions(-)
>
applied series, thanks!
prev parent reply other threads:[~2020-10-13 9:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-12 15:34 [pve-devel] " Stoiko Ivanov
2020-10-12 15:34 ` [pve-devel] [PATCH storage 1/2] LIO: untaint values read from remote config Stoiko Ivanov
2020-10-12 15:34 ` [pve-devel] [PATCH storage 2/2] LIO: drop unused statements Stoiko Ivanov
2020-10-12 16:37 ` [pve-devel] [PATCH storage 0/2] LIO: fix tainted config and minor cleanup Daniel Berteaud
2020-10-13 9:15 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ba6ae54b-6eef-3ca3-438f-45fbb1057889@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=s.ivanov@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.